diff options
| author | Lukáš Tyrychtr <lukastyrychtr@gmail.com> | 2022-07-26 14:04:46 +0300 |
|---|---|---|
| committer | Christopher Ng <chrng8@gmail.com> | 2022-08-03 22:33:12 +0300 |
| commit | d760cde5356760f1c677b336dbb378a7716df0f1 (patch) | |
| tree | 933781fb0c6a842611efe64b04eae740ee8419f3 | |
| parent | 392b08d7611e05a75aa97934ef8ba23a7b8d1f92 (diff) | |
Fix accessibility of buttons in the external storage configurationexternal_storage_buttons_a11y
Note that there is no keyboard only way to close the dropdown
Signed-off-by: Christopher Ng <chrng8@gmail.com>
| -rw-r--r-- | apps/files_external/css/settings.css | 3 | ||||
| -rw-r--r-- | apps/files_external/css/settings.css.map | 2 | ||||
| -rw-r--r-- | apps/files_external/css/settings.scss | 3 | ||||
| -rw-r--r-- | apps/files_external/js/settings.js | 2 | ||||
| -rw-r--r-- | apps/files_external/templates/settings.php | 4 |
5 files changed, 11 insertions, 3 deletions
diff --git a/apps/files_external/css/settings.css b/apps/files_external/css/settings.css index 84e382ceb89..778e2292932 100644 --- a/apps/files_external/css/settings.css +++ b/apps/files_external/css/settings.css @@ -68,6 +68,9 @@ #externalStorage td.mountOptionsToggle [class*=" icon-"], #externalStorage td.remove [class^=icon-], #externalStorage td.remove [class*=" icon-"], #externalStorage td.save [class^=icon-], #externalStorage td.save [class*=" icon-"] { + width: 44px; + height: 44px; + margin: 3px; opacity: 0.5; padding: 14px; vertical-align: text-bottom; diff --git a/apps/files_external/css/settings.css.map b/apps/files_external/css/settings.css.map index d084c036f9a..b767a2be016 100644 --- a/apps/files_external/css/settings.css.map +++ b/apps/files_external/css/settings.css.map @@ -1 +1 @@ -{"version":3,"sourceRoot":"","sources":["settings.scss"],"names":[],"mappings":"AAAA;EACC;;;AAGD;EACC;;AAEA;EACC;;;AAKD;EACC;;;AAIF;AACC;EACA;EACA;;;AAGD;EACC;EACA;EACA;EACA;EACA;EACA;;;AAGA;EACC;EACA;;;AAGF;EAA0B;EAAiB;;;AAC3C;EAAgC;EAAiB;EAAgB;;;AACjE;EAAoB;;;AACpB;EAA+B;;;AAC/B;EAA2B;;;AAE3B;EACC;;AACA;EAGC;EACA;EACA;;AACA;AAAA;AAAA;AAAA;EAEC;EACA;EACA;EACA;;AACA;AAAA;AAAA;AAAA;EACC;;;AAMJ;EACC;EACA;;;AAGD;AAAA;EAEC;;;AAED;EACC;;;AAGD;EACC;;;AAGD;EACC;;;AAGD;EACC;EACA;EACA;;;AAGD;EACC;;;AAID;EACC;EACA;;;AAGD;EACC;;;AAGD;EACC;;;AAGD;EACC;EACA;;;AAED;EACC;EACA;;;AAED;EACC;;;AAED;EACC;EACA;EACA;;;AAED;EACC;EACA;EACA;EACA;EACA;EACA;EACA;EACA;;;AAGD;EACC;;AACA;EACC;EACA;EACA;EACA;;;AAIF;EACC;;;AAGD;EACC","file":"settings.css"}
\ No newline at end of file +{"version":3,"sourceRoot":"","sources":["settings.scss"],"names":[],"mappings":"AAAA;EACC;;;AAGD;EACC;;AAEA;EACC;;;AAKD;EACC;;;AAIF;AACC;EACA;EACA;;;AAGD;EACC;EACA;EACA;EACA;EACA;EACA;;;AAGA;EACC;EACA;;;AAGF;EAA0B;EAAiB;;;AAC3C;EAAgC;EAAiB;EAAgB;;;AACjE;EAAoB;;;AACpB;EAA+B;;;AAC/B;EAA2B;;;AAE3B;EACC;;AACA;EAGC;EACA;EACA;;AACA;AAAA;AAAA;AAAA;EAEC;EACA;EACA;EACA;EACA;EACA;EACA;;AACA;AAAA;AAAA;AAAA;EACC;;;AAMJ;EACC;EACA;;;AAGD;AAAA;EAEC;;;AAED;EACC;;;AAGD;EACC;;;AAGD;EACC;;;AAGD;EACC;EACA;EACA;;;AAGD;EACC;;;AAID;EACC;EACA;;;AAGD;EACC;;;AAGD;EACC;;;AAGD;EACC;EACA;;;AAED;EACC;EACA;;;AAED;EACC;;;AAED;EACC;EACA;EACA;;;AAED;EACC;EACA;EACA;EACA;EACA;EACA;EACA;EACA;;;AAGD;EACC;;AACA;EACC;EACA;EACA;EACA;;;AAIF;EACC;;;AAGD;EACC","file":"settings.css"}
\ No newline at end of file diff --git a/apps/files_external/css/settings.scss b/apps/files_external/css/settings.scss index f4d8b677d96..ce30aa556c7 100644 --- a/apps/files_external/css/settings.scss +++ b/apps/files_external/css/settings.scss @@ -52,6 +52,9 @@ width: 44px; [class^='icon-'], [class*=' icon-'] { + width: 44px; + height: 44px; + margin: 3px; opacity: 0.5; padding: 14px; vertical-align: text-bottom; diff --git a/apps/files_external/js/settings.js b/apps/files_external/js/settings.js index 0a791001f63..765850e2ef2 100644 --- a/apps/files_external/js/settings.js +++ b/apps/files_external/js/settings.js @@ -715,6 +715,7 @@ MountConfigListView.prototype = _.extend({ }); this.$el.on('click', 'td.mountOptionsToggle>.icon-more', function() { + $(this).attr('aria-expanded', 'true'); self._showMountOptionsDropdown($(this).closest('tr')); }); @@ -1343,6 +1344,7 @@ MountConfigListView.prototype = _.extend({ var mountOptions = dropDown.getOptions(); $('body').off('mouseup.mountOptionsDropdown'); $tr.find('input.mountOptions').val(JSON.stringify(mountOptions)); + $tr.find('td.mountOptionsToggle>.icon-more').attr('aria-expanded', 'false'); self.saveStorageConfig($tr); }); } diff --git a/apps/files_external/templates/settings.php b/apps/files_external/templates/settings.php index 48067529723..d8dd91822c5 100644 --- a/apps/files_external/templates/settings.php +++ b/apps/files_external/templates/settings.php @@ -173,11 +173,11 @@ $canCreateMounts = $_['visibilityType'] === BackendService::VISIBILITY_ADMIN || </td> <?php endif; ?> <td class="mountOptionsToggle hidden"> - <div class="icon-more" title="<?php p($l->t('Advanced settings')); ?>"></div> + <button type="button" class="icon-more" aria-expanded="false" title="<?php p($l->t('Advanced settings')); ?>"></button> <input type="hidden" class="mountOptions" value="" /> </td> <td class="save hidden"> - <div class="icon-checkmark" title="<?php p($l->t('Save')); ?>"></div> + <button type="button" class="icon-checkmark" title="<?php p($l->t('Save')); ?>"></button> </td> </tr> </tbody> |