diff options
| author | Joas Schilling <213943+nickvergessen@users.noreply.github.com> | 2022-06-03 16:31:40 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-03 16:31:40 +0300 |
| commit | 6d5d91f6f93acbbd9886714ca59ebcc31578bd31 (patch) | |
| tree | 5bf09af2d57c517199c47c72336e04c53370e966 | |
| parent | 57c686e1247e3249634a8e93b3c7168a67d0fb9d (diff) | |
| parent | 5b82ad0b306034e299e965f5f43542e071b29c0f (diff) | |
Merge pull request #32556 from nextcloud/bugfix/noid/fix-comments-query-handling
Create query parameters on correct objects to make debugging easier
| -rw-r--r-- | lib/private/Comments/Manager.php | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/private/Comments/Manager.php b/lib/private/Comments/Manager.php index 4a06ac62f1e..b7532222c33 100644 --- a/lib/private/Comments/Manager.php +++ b/lib/private/Comments/Manager.php @@ -1258,8 +1258,6 @@ class Manager implements ICommentsManager { } private function sumReactions(string $parentId): void { - $qb = $this->dbConn->getQueryBuilder(); - $totalQuery = $this->dbConn->getQueryBuilder(); $totalQuery ->selectAlias( @@ -1273,7 +1271,7 @@ class Manager implements ICommentsManager { ) ->selectAlias($totalQuery->func()->count('id'), 'total') ->from('reactions', 'r') - ->where($totalQuery->expr()->eq('r.parent_id', $qb->createNamedParameter($parentId))) + ->where($totalQuery->expr()->eq('r.parent_id', $totalQuery->createNamedParameter($parentId))) ->groupBy('r.reaction') ->orderBy('total', 'DESC') ->addOrderBy('r.reaction', 'ASC') @@ -1291,9 +1289,10 @@ class Manager implements ICommentsManager { ) ->from($jsonQuery->createFunction('(' . $totalQuery->getSQL() . ')'), 'json'); + $qb = $this->dbConn->getQueryBuilder(); $qb ->update('comments') - ->set('reactions', $jsonQuery->createFunction('(' . $jsonQuery->getSQL() . ')')) + ->set('reactions', $qb->createFunction('(' . $jsonQuery->getSQL() . ')')) ->where($qb->expr()->eq('id', $qb->createNamedParameter($parentId))) ->executeStatement(); } |