diff options
author | Morris Jobke <hey@morrisjobke.de> | 2015-10-09 14:19:35 +0300 |
---|---|---|
committer | Morris Jobke <hey@morrisjobke.de> | 2015-10-09 14:19:35 +0300 |
commit | 4c13a648bbdef70fdc318709bd712b41cdcdb944 (patch) | |
tree | 0e93984de349cd7c3f34d24ea44f79a7016319b4 | |
parent | c3ec3b0fe05383837620285457144a8524837123 (diff) | |
parent | 76399dc6b07f4fc215317940fc9df0cb294d8d09 (diff) |
Merge pull request #18855 from owncloud/memcached-fix-stable8.1
[stable8.1] Fallback to complete Memcached flush if getAllKeys fails
-rw-r--r-- | lib/private/memcache/memcached.php | 5 | ||||
-rw-r--r-- | tests/lib/memcache/memcached.php | 23 |
2 files changed, 28 insertions, 0 deletions
diff --git a/lib/private/memcache/memcached.php b/lib/private/memcache/memcached.php index 1503851fd73..e99303ecc15 100644 --- a/lib/private/memcache/memcached.php +++ b/lib/private/memcache/memcached.php @@ -89,6 +89,11 @@ class Memcached extends Cache implements IMemcache { public function clear($prefix = '') { $prefix = $this->getNamespace() . $prefix; $allKeys = self::$cache->getAllKeys(); + if ($allKeys === false) { + // newer Memcached doesn't like getAllKeys(), flush everything + self::$cache->flush(); + return true; + } $keys = array(); $prefixLength = strlen($prefix); foreach ($allKeys as $key) { diff --git a/tests/lib/memcache/memcached.php b/tests/lib/memcache/memcached.php index 51a78996dd4..3ea9216029a 100644 --- a/tests/lib/memcache/memcached.php +++ b/tests/lib/memcache/memcached.php @@ -26,4 +26,27 @@ class Memcached extends Cache { parent::setUp(); $this->instance = new \OC\Memcache\Memcached($this->getUniqueID()); } + + public function testClear() { + // Memcached is sometimes broken with clear(), so we don't test it thoroughly + $value='ipsum lorum'; + $this->instance->set('1_value1', $value); + $this->instance->set('1_value2', $value); + $this->instance->set('2_value1', $value); + $this->instance->set('3_value1', $value); + + $this->assertTrue($this->instance->clear('1_')); + + $this->assertFalse($this->instance->hasKey('1_value1')); + $this->assertFalse($this->instance->hasKey('1_value2')); + //$this->assertTrue($this->instance->hasKey('2_value1')); + //$this->assertTrue($this->instance->hasKey('3_value1')); + + $this->assertTrue($this->instance->clear()); + + $this->assertFalse($this->instance->hasKey('1_value1')); + $this->assertFalse($this->instance->hasKey('1_value2')); + $this->assertFalse($this->instance->hasKey('2_value1')); + $this->assertFalse($this->instance->hasKey('3_value1')); + } } |