diff options
author | Pytal <24800714+Pytal@users.noreply.github.com> | 2022-07-07 01:39:28 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-07-07 01:39:28 +0300 |
commit | 869335fc47f2468fcd7f112396a66b4459e2a5bf (patch) | |
tree | dd8f0d84c825ba02e0217abfac527b4126632e75 | |
parent | ce983ec177f5d1a313de068b7cbcaf35cfb17af7 (diff) | |
parent | a06f0274fe0ae93b04f60166b040744a0646488c (diff) |
Merge pull request #33144 from nextcloud/backport/33052/stable23
4 files changed, 11 insertions, 3 deletions
diff --git a/apps/provisioning_api/lib/Controller/UsersController.php b/apps/provisioning_api/lib/Controller/UsersController.php index a26479ba0a8..839ac404c94 100644 --- a/apps/provisioning_api/lib/Controller/UsersController.php +++ b/apps/provisioning_api/lib/Controller/UsersController.php @@ -837,7 +837,9 @@ class UsersController extends AUserData { switch ($key) { case self::USER_FIELD_DISPLAYNAME: case IAccountManager::PROPERTY_DISPLAYNAME: - $targetUser->setDisplayName($value); + if (!$targetUser->setDisplayName($value)) { + throw new OCSException('Invalid displayname', 102); + } break; case self::USER_FIELD_QUOTA: $quota = $value; diff --git a/apps/provisioning_api/tests/Controller/UsersControllerTest.php b/apps/provisioning_api/tests/Controller/UsersControllerTest.php index 6162be54a04..4449302fedd 100644 --- a/apps/provisioning_api/tests/Controller/UsersControllerTest.php +++ b/apps/provisioning_api/tests/Controller/UsersControllerTest.php @@ -1486,7 +1486,8 @@ class UsersControllerTest extends TestCase { $targetUser ->expects($this->once()) ->method('setDisplayName') - ->with('NewDisplayName'); + ->with('NewDisplayName') + ->willReturn(true); $targetUser ->expects($this->any()) ->method('getUID') diff --git a/apps/settings/js/federationsettingsview.js b/apps/settings/js/federationsettingsview.js index ca56992b1ed..c91d34530c1 100644 --- a/apps/settings/js/federationsettingsview.js +++ b/apps/settings/js/federationsettingsview.js @@ -128,7 +128,8 @@ _.each(this._inputFields, function(field) { if ( field === 'avatar' || - field === 'email' + field === 'email' || + field === 'displayname' ) { return; } diff --git a/lib/private/User/Database.php b/lib/private/User/Database.php index 5dfc74163a7..79a01c55ed0 100644 --- a/lib/private/User/Database.php +++ b/lib/private/User/Database.php @@ -209,6 +209,10 @@ class Database extends ABackend implements * Change the display name of a user */ public function setDisplayName(string $uid, string $displayName): bool { + if (mb_strlen($displayName) > 64) { + return false; + } + $this->fixDI(); if ($this->userExists($uid)) { |