Move Files app to PSR-4 (#24569)

* Move lib/ of Files app to PSR-4

* Move tests to PSR-4

23 files changed, 10 insertions, 11 deletions

diff --git a/apps/files/lib/activity.php b/apps/files/lib/Activity.php
index 1cbd6c3b973..1cbd6c3b973 100644
--- a/apps/files/lib/activity.php
+++ b/apps/files/lib/Activity.php
diff --git a/apps/files/lib/activityhelper.php b/apps/files/lib/ActivityHelper.php
index 046dd59bc76..046dd59bc76 100644
--- a/apps/files/lib/activityhelper.php
+++ b/apps/files/lib/ActivityHelper.php
diff --git a/apps/files/lib/app.php b/apps/files/lib/App.php
index 981c41ff413..981c41ff413 100644
--- a/apps/files/lib/app.php
+++ b/apps/files/lib/App.php
diff --git a/apps/files/appinfo/application.php b/apps/files/lib/AppInfo/Application.php
index b2faa43cc3c..b2faa43cc3c 100644
--- a/apps/files/appinfo/application.php
+++ b/apps/files/lib/AppInfo/Application.php
diff --git a/apps/files/lib/backgroundjob/cleanupfilelocks.php b/apps/files/lib/BackgroundJob/CleanupFileLocks.php
index b5cf8e94551..b5cf8e94551 100644
--- a/apps/files/lib/backgroundjob/cleanupfilelocks.php
+++ b/apps/files/lib/BackgroundJob/CleanupFileLocks.php
diff --git a/apps/files/lib/backgroundjob/deleteorphaneditems.php b/apps/files/lib/BackgroundJob/DeleteOrphanedItems.php
index 1eef9c24e0c..1eef9c24e0c 100644
--- a/apps/files/lib/backgroundjob/deleteorphaneditems.php
+++ b/apps/files/lib/BackgroundJob/DeleteOrphanedItems.php
diff --git a/apps/files/lib/backgroundjob/scanfiles.php b/apps/files/lib/BackgroundJob/ScanFiles.php
index dcc180bcfbe..dcc180bcfbe 100644
--- a/apps/files/lib/backgroundjob/scanfiles.php
+++ b/apps/files/lib/BackgroundJob/ScanFiles.php
diff --git a/apps/files/lib/capabilities.php b/apps/files/lib/Capabilities.php
index dc49ca174b3..dc49ca174b3 100644
--- a/apps/files/lib/capabilities.php
+++ b/apps/files/lib/Capabilities.php
diff --git a/apps/files/command/deleteorphanedfiles.php b/apps/files/lib/Command/DeleteOrphanedFiles.php
index 91043471ce5..91043471ce5 100644
--- a/apps/files/command/deleteorphanedfiles.php
+++ b/apps/files/lib/Command/DeleteOrphanedFiles.php
diff --git a/apps/files/command/scan.php b/apps/files/lib/Command/Scan.php
index 1ae04c585bb..1ae04c585bb 100644
--- a/apps/files/command/scan.php
+++ b/apps/files/lib/Command/Scan.php
diff --git a/apps/files/command/transferownership.php b/apps/files/lib/Command/TransferOwnership.php
index 1f46efdde0d..1f46efdde0d 100644
--- a/apps/files/command/transferownership.php
+++ b/apps/files/lib/Command/TransferOwnership.php
diff --git a/apps/files/controller/apicontroller.php b/apps/files/lib/Controller/ApiController.php
index 072498c7b5f..072498c7b5f 100644
--- a/apps/files/controller/apicontroller.php
+++ b/apps/files/lib/Controller/ApiController.php
diff --git a/apps/files/controller/viewcontroller.php b/apps/files/lib/Controller/ViewController.php
index 7539a3ab649..7539a3ab649 100644
--- a/apps/files/controller/viewcontroller.php
+++ b/apps/files/lib/Controller/ViewController.php
diff --git a/apps/files/lib/helper.php b/apps/files/lib/Helper.php
index d21a65afcee..d21a65afcee 100644
--- a/apps/files/lib/helper.php
+++ b/apps/files/lib/Helper.php
diff --git a/apps/files/service/tagservice.php b/apps/files/lib/Service/TagService.php
index 57cad43a539..57cad43a539 100644
--- a/apps/files/service/tagservice.php
+++ b/apps/files/lib/Service/TagService.php
diff --git a/apps/files/tests/activitytest.php b/apps/files/tests/ActivityTest.php
index bc062dd0542..bc062dd0542 100644
--- a/apps/files/tests/activitytest.php
+++ b/apps/files/tests/ActivityTest.php
diff --git a/apps/files/tests/backgroundjob/DeleteOrphanedItemsJobTest.php b/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php
index e802a248a9b..e802a248a9b 100644
--- a/apps/files/tests/backgroundjob/DeleteOrphanedItemsJobTest.php
+++ b/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php
diff --git a/apps/files/tests/backgroundjob/ScanFilesTest.php b/apps/files/tests/BackgroundJob/ScanFilesTest.php
index eab28071b70..eab28071b70 100644
--- a/apps/files/tests/backgroundjob/ScanFilesTest.php
+++ b/apps/files/tests/BackgroundJob/ScanFilesTest.php
diff --git a/apps/files/tests/command/deleteorphanedfilestest.php b/apps/files/tests/Command/DeleteOrphanedFilesTest.php
index ff29942bc4a..ff29942bc4a 100644
--- a/apps/files/tests/command/deleteorphanedfilestest.php
+++ b/apps/files/tests/Command/DeleteOrphanedFilesTest.php
diff --git a/apps/files/tests/controller/apicontrollertest.php b/apps/files/tests/Controller/ApiControllerTest.php
index 2eba7d62feb..2eba7d62feb 100644
--- a/apps/files/tests/controller/apicontrollertest.php
+++ b/apps/files/tests/Controller/ApiControllerTest.php
diff --git a/apps/files/tests/controller/ViewControllerTest.php b/apps/files/tests/Controller/ViewControllerTest.php
index 4e4e88043e4..affcdb53a4b 100644
--- a/apps/files/tests/controller/ViewControllerTest.php
+++ b/apps/files/tests/Controller/ViewControllerTest.php
@@ -26,6 +26,7 @@ namespace OCA\Files\Tests\Controller;
 
 use OCA\Files\Controller\ViewController;
 use OCP\AppFramework\Http;
+use OCP\IUser;
 use OCP\Template;
 use Test\TestCase;
 use OCP\IRequest;
diff --git a/apps/files/tests/helper.php b/apps/files/tests/HelperTest.php
index 654ec8332ed..d2d52b4f8a3 100644
--- a/apps/files/tests/helper.php
+++ b/apps/files/tests/HelperTest.php
@@ -23,12 +23,12 @@
  *
  */
 
-use OCA\Files;
+use OCA\Files\Tests;
 
 /**
- * Class Test_Files_Helper
+ * Class Helper
  */
-class Test_Files_Helper extends \Test\TestCase {
+class HelperTest extends \Test\TestCase {
 
 	private function makeFileInfo($name, $size, $mtime, $isDir = false) {
 		return new \OC\Files\FileInfo(
diff --git a/apps/files/tests/service/tagservice.php b/apps/files/tests/Service/TagServiceTest.php
index 5fcf64b1352..3f210b500ff 100644
--- a/apps/files/tests/service/tagservice.php
+++ b/apps/files/tests/Service/TagServiceTest.php
@@ -20,9 +20,9 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
-namespace OCA\Files;
+namespace OCA\Files\Tests\Service;
 
-use \OCA\Files\Service\TagService;
+use OCA\Files\Service\TagService;
 
 /**
  * Class TagServiceTest
@@ -55,13 +55,11 @@ class TagServiceTest extends \Test\TestCase {
 
 	protected function setUp() {
 		parent::setUp();
-		$this->user = $this->getUniqueId('user');
+		$this->user = $this->getUniqueID('user');
 		\OC::$server->getUserManager()->createUser($this->user, 'test');
 		\OC_User::setUserId($this->user);
 		\OC_Util::setupFS($this->user);
-		/**
-		 * @var \OCP\IUser
-		 */
+		/** @var \OCP\IUser */
 		$user = new \OC\User\User($this->user, null);
 		/**
 		 * @var \OCP\IUserSession
@@ -105,12 +103,12 @@ class TagServiceTest extends \Test\TestCase {
 		$this->assertEquals(array($fileId), $this->tagger->getIdsForTag($tag2));
 
 		// remove tag
-		$result = $this->tagService->updateFileTags('subdir/test.txt', array($tag2));
+		$this->tagService->updateFileTags('subdir/test.txt', array($tag2));
 		$this->assertEquals(array(), $this->tagger->getIdsForTag($tag1));
 		$this->assertEquals(array($fileId), $this->tagger->getIdsForTag($tag2));
 
 		// clear tags
-		$result = $this->tagService->updateFileTags('subdir/test.txt', array());
+		$this->tagService->updateFileTags('subdir/test.txt', array());
 		$this->assertEquals(array(), $this->tagger->getIdsForTag($tag1));
 		$this->assertEquals(array(), $this->tagger->getIdsForTag($tag2));