Fix unit tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

1 files changed, 31 insertions, 8 deletions

diff --git a/apps/settings/tests/Settings/Admin/ServerTest.php b/apps/settings/tests/Settings/Admin/ServerTest.php
index aeb37f8d6cc..9657ec2d2d4 100644
--- a/apps/settings/tests/Settings/Admin/ServerTest.php
+++ b/apps/settings/tests/Settings/Admin/ServerTest.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
  *
@@ -31,25 +32,46 @@ namespace OCA\Settings\Tests\Settings\Admin;
 
 use OCA\Settings\Settings\Admin\Server;
 use OCP\AppFramework\Http\TemplateResponse;
+use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\IConfig;
+use OCP\IDBConnection;
+use PHPUnit\Framework\MockObject\MockObject;
 use Test\TestCase;
 
+
+/**
+ * @group DB
+ */
 class ServerTest extends TestCase {
 	/** @var Server */
 	private $admin;
-	/** @var IConfig */
+	/** @var IDBConnection */
+	private $connection;
+	/** @var ITimeFactory|MockObject */
+	private $timeFactory;
+	/** @var IConfig|MockObject */
 	private $config;
 
 	protected function setUp(): void {
 		parent::setUp();
+		$this->connection = \OC::$server->getDatabaseConnection();
+		$this->timeFactory = $this->createMock(ITimeFactory::class);
 		$this->config = $this->createMock(IConfig::class);
 
-		$this->admin = new Server(
-			$this->config
-		);
+		$this->admin = $this->getMockBuilder(Server::class)
+			->onlyMethods(['cronMaxAge'])
+			->setConstructorArgs([
+				$this->connection,
+				$this->timeFactory,
+				$this->config,
+			])
+			->getMock();
 	}
 
-	public function testGetForm() {
+	public function testGetForm(): void {
+		$this->admin->expects($this->once())
+			->method('cronMaxAge')
+			->willReturn(1337);
 		$this->config
 			->expects($this->at(0))
 			->method('getAppValue')
@@ -71,7 +93,8 @@ class ServerTest extends TestCase {
 			[
 				'backgroundjobs_mode' => 'ajax',
 				'lastcron'            => false,
-				'cronErrors'		  => '',
+				'cronErrors'          => '',
+				'cronMaxAge'          => 1337,
 				'cli_based_cron_possible' => true,
 				'cli_based_cron_user' => function_exists('posix_getpwuid') ? posix_getpwuid(fileowner(\OC::$configDir . 'config.php'))['name'] : '', // to not explode here because of posix extension not being disabled - which is already checked in the line above
 			],
@@ -81,11 +104,11 @@ class ServerTest extends TestCase {
 		$this->assertEquals($expected, $this->admin->getForm());
 	}
 
-	public function testGetSection() {
+	public function testGetSection(): void {
 		$this->assertSame('server', $this->admin->getSection());
 	}
 
-	public function testGetPriority() {
+	public function testGetPriority(): void {
 		$this->assertSame(0, $this->admin->getPriority());
 	}
 }