diff options
| author | szaimen <szaimen@e.mail.de> | 2022-06-16 18:53:23 +0300 |
|---|---|---|
| committer | szaimen <szaimen@e.mail.de> | 2022-06-21 20:08:51 +0300 |
| commit | 46c7a974d5a8443f4bcaeae8bf4da541d7adcadd (patch) | |
| tree | 5dcd11ae24920c04ced8842864b2e4b2aa8fa79b /apps/settings | |
| parent | 9b9a4f2a67bd26bb93ff1041801e60951d06b191 (diff) | |
do not display the buffer_size info if the size is already set to a certain thresholdbackport/32902/stable24
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
Diffstat (limited to 'apps/settings')
| -rw-r--r-- | apps/settings/lib/Controller/CheckSetupController.php | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index b9f176f97c5..f52c10cf580 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -525,7 +525,11 @@ Raw output if ( empty($status['interned_strings_usage']['free_memory']) || - ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) + ( + ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) && + // Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size + ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) + ) ) { $recommendations[] = $this->l10n->t('The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply <code>opcache.interned_strings_buffer</code> to your PHP configuration with a value higher than <code>%s</code>.', [($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?: 'currently')]); } |