group display name support (service level + ldap)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

1 files changed, 39 insertions, 0 deletions

diff --git a/apps/user_ldap/tests/Group_LDAPTest.php b/apps/user_ldap/tests/Group_LDAPTest.php
index cb5760e3171..a505c403acb 100644
--- a/apps/user_ldap/tests/Group_LDAPTest.php
+++ b/apps/user_ldap/tests/Group_LDAPTest.php
@@ -1057,4 +1057,43 @@ class Group_LDAPTest extends TestCase {
 		$this->assertEquals($expectedMembers, $resultingMembers, '', 0.0, 10, true);
 	}
 
+	public function displayNameProvider() {
+		return [
+			['Graphic Novelists', ['Graphic Novelists']],
+			['', false],
+		];
+	}
+
+	/**
+	 * @dataProvider displayNameProvider
+	 */
+	public function testGetDisplayName(string $expected, $ldapResult) {
+		$gid = 'graphic_novelists';
+
+		$access = $this->getAccessMock();
+		$access->expects($this->atLeastOnce())
+			->method('readAttribute')
+			->willReturn($ldapResult);
+
+		$access->connection = $this->createMock(Connection::class);
+		$access->connection->expects($this->any())
+			->method('__get')
+			->willReturnCallback(function($name) {
+				if($name === 'ldapGroupMemberAssocAttr') {
+					return 'member';
+				} else if($name === 'ldapGroupFilter') {
+					return 'objectclass=nextcloudGroup';
+				} else if($name === 'ldapGroupDisplayName') {
+					return 'cn';
+				}
+				return null;
+			});
+
+		/** @var GroupPluginManager $pluginManager */
+		$pluginManager = $this->createMock(GroupPluginManager::class);
+
+		$ldap = new GroupLDAP($access, $pluginManager);
+		$this->assertSame($expected, $ldap->getDisplayName($gid));
+	}
+
 }