diff options
author | Robin Appelman <robin@icewind.nl> | 2021-10-07 17:11:49 +0300 |
---|---|---|
committer | Robin Appelman <robin@icewind.nl> | 2022-01-13 17:45:08 +0300 |
commit | 9f2b50db193796bdc61ddeb61116b25e26f8614e (patch) | |
tree | d40bad434c3377f12764cceb0266f1be6225ab00 /core | |
parent | b62f8795f34dfeb98576ef801e4655be44a2b745 (diff) |
add better index for finding unindexed paths
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'
currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.
by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up
Signed-off-by: Robin Appelman <robin@icewind.nl>
Diffstat (limited to 'core')
-rw-r--r-- | core/Application.php | 4 | ||||
-rw-r--r-- | core/Command/Db/AddMissingIndices.php | 7 | ||||
-rw-r--r-- | core/Migrations/Version13000Date20170718121200.php | 1 |
3 files changed, 12 insertions, 0 deletions
diff --git a/core/Application.php b/core/Application.php index 882bbc916b7..edea929ba8d 100644 --- a/core/Application.php +++ b/core/Application.php @@ -119,6 +119,10 @@ class Application extends App { if (!$table->hasIndex('fs_storage_path_prefix') && !$schema->getDatabasePlatform() instanceof PostgreSQL94Platform) { $subject->addHintForMissingSubject($table->getName(), 'fs_storage_path_prefix'); } + + if (!$table->hasIndex('fs_id_storage_size')) { + $subject->addHintForMissingSubject($table->getName(), 'fs_id_storage_size'); + } } if ($schema->hasTable('twofactor_providers')) { diff --git a/core/Command/Db/AddMissingIndices.php b/core/Command/Db/AddMissingIndices.php index ef0c24dd8af..90281dfb36d 100644 --- a/core/Command/Db/AddMissingIndices.php +++ b/core/Command/Db/AddMissingIndices.php @@ -152,6 +152,13 @@ class AddMissingIndices extends Command { $updated = true; $output->writeln('<info>Filecache table updated successfully.</info>'); } + if (!$table->hasIndex('fs_id_storage_size')) { + $output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>'); + $table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size'); + $this->connection->migrateToSchema($schema->getWrappedSchema()); + $updated = true; + $output->writeln('<info>Filecache table updated successfully.</info>'); + } } $output->writeln('<info>Check indices of the twofactor_providers table.</info>'); diff --git a/core/Migrations/Version13000Date20170718121200.php b/core/Migrations/Version13000Date20170718121200.php index 65a7a89576e..02864830b2c 100644 --- a/core/Migrations/Version13000Date20170718121200.php +++ b/core/Migrations/Version13000Date20170718121200.php @@ -262,6 +262,7 @@ class Version13000Date20170718121200 extends SimpleMigrationStep { $table->addIndex(['storage', 'mimetype'], 'fs_storage_mimetype'); $table->addIndex(['storage', 'mimepart'], 'fs_storage_mimepart'); $table->addIndex(['storage', 'size', 'fileid'], 'fs_storage_size'); + $table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size'); $table->addIndex(['mtime'], 'fs_mtime'); $table->addIndex(['size'], 'fs_size'); if (!$schema->getDatabasePlatform() instanceof PostgreSQL94Platform) { |