some minor fixes and clode cleanup

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

9 files changed, 86 insertions, 3 deletions

diff --git a/lib/public/Federation/Exceptions/ActionNotSupportedException.php b/lib/public/Federation/Exceptions/ActionNotSupportedException.php
index 7e7fe70f480..2d295bd9d8b 100644
--- a/lib/public/Federation/Exceptions/ActionNotSupportedException.php
+++ b/lib/public/Federation/Exceptions/ActionNotSupportedException.php
@@ -23,11 +23,20 @@ namespace OCP\Federation\Exceptions;
 
 use OC\HintException;
 
+/**
+ * Class ActionNotSupportedException
+ *
+ * @package OCP\Federation\Exceptions
+ *
+ * @since 14.0.0
+ */
 class ActionNotSupportedException extends HintException {
 
 	/**
 	 * ActionNotSupportedException constructor.
 	 *
+	 * @since 14.0.0
+	 *
 	 */
 	public function __construct($action) {
 		$l = \OC::$server->getL10N('federation');
diff --git a/lib/public/Federation/Exceptions/AuthenticationFailedException.php b/lib/public/Federation/Exceptions/AuthenticationFailedException.php
index a9a412dd835..1ea7ec5cd31 100644
--- a/lib/public/Federation/Exceptions/AuthenticationFailedException.php
+++ b/lib/public/Federation/Exceptions/AuthenticationFailedException.php
@@ -23,12 +23,20 @@ namespace OCP\Federation\Exceptions;
 
 use OC\HintException;
 
+/**
+ * Class AuthenticationFailedException
+ *
+ * @package OCP\Federation\Exceptions
+ *
+ * @since 14.0.0
+ */
 class AuthenticationFailedException extends HintException {
 
 	/**
 	 * BadRequestException constructor.
 	 *
-	 * @param array $missingParameters
+	 * @since 14.0.0
+	 *
 	 */
 	public function __construct() {
 		$l = \OC::$server->getL10N('federation');
diff --git a/lib/public/Federation/Exceptions/BadRequestException.php b/lib/public/Federation/Exceptions/BadRequestException.php
index 67cf911c2a0..9d9e48157a1 100644
--- a/lib/public/Federation/Exceptions/BadRequestException.php
+++ b/lib/public/Federation/Exceptions/BadRequestException.php
@@ -23,6 +23,13 @@ namespace OCP\Federation\Exceptions;
 
 use OC\HintException;
 
+/**
+ * Class BadRequestException
+ *
+ * @package OCP\Federation\Exceptions
+ *
+ * @since 14.0.0
+ */
 class BadRequestException extends HintException {
 
 	private $parameterList;
@@ -30,6 +37,8 @@ class BadRequestException extends HintException {
 	/**
 	 * BadRequestException constructor.
 	 *
+	 * @since 14.0.0
+	 *
 	 * @param array $missingParameters
 	 */
 	public function __construct(array $missingParameters) {
@@ -44,6 +53,8 @@ class BadRequestException extends HintException {
 	/**
 	 * get array with the return message as defined in the OCM API
 	 *
+	 * @since 14.0.0
+	 *
 	 * @return array
 	 */
 	public function getReturnMessage() {
diff --git a/lib/public/Federation/Exceptions/ProviderAlreadyExistsException.php b/lib/public/Federation/Exceptions/ProviderAlreadyExistsException.php
index f053a02fbea..e5022500d1c 100644
--- a/lib/public/Federation/Exceptions/ProviderAlreadyExistsException.php
+++ b/lib/public/Federation/Exceptions/ProviderAlreadyExistsException.php
@@ -23,11 +23,20 @@ namespace OCP\Federation\Exceptions;
 
 use OC\HintException;
 
+/**
+ * Class ProviderAlreadyExistsException
+ *
+ * @package OCP\Federation\Exceptions
+ *
+ * @since 14.0.0
+ */
 class ProviderAlreadyExistsException extends HintException {
 
 	/**
 	 * ProviderAlreadyExistsException constructor.
 	 *
+	 * @since 14.0.0
+	 *
 	 * @param string $newProviderId cloud federation provider ID of the new provider
 	 * @param string $existingProviderName name of cloud federation provider which already use the same ID
 	 */
diff --git a/lib/public/Federation/Exceptions/ProviderCouldNotAddShareException.php b/lib/public/Federation/Exceptions/ProviderCouldNotAddShareException.php
index 205206d5af8..80613cc29ac 100644
--- a/lib/public/Federation/Exceptions/ProviderCouldNotAddShareException.php
+++ b/lib/public/Federation/Exceptions/ProviderCouldNotAddShareException.php
@@ -24,8 +24,25 @@ namespace OCP\Federation\Exceptions;
 use OC\HintException;
 use OCP\AppFramework\Http;
 
+/**
+ * Class ProviderCouldNotAddShareException
+ *
+ * @package OCP\Federation\Exceptions
+ *
+ * @since 14.0.0
+ */
 class ProviderCouldNotAddShareException extends HintException {
 
+	/**
+	 * ProviderCouldNotAddShareException constructor.
+	 *
+	 * @since 14.0.0
+	 *
+	 * @param string $message
+	 * @param string $hint
+	 * @param int $code
+	 * @param \Exception|null $previous
+	 */
 	public function __construct($message, $hint = '', $code = Http::STATUS_BAD_REQUEST, \Exception $previous = null) {
 		parent::__construct($message, $hint, $code, $previous);
 	}
diff --git a/lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php b/lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php
index 8f760d6abf4..761fcaf809d 100644
--- a/lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php
+++ b/lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php
@@ -23,11 +23,20 @@ namespace OCP\Federation\Exceptions;
 
 use OC\HintException;
 
+/**
+ * Class ProviderDoesNotExistsException
+ *
+ * @package OCP\Federation\Exceptions
+ *
+ * @since 14.0.0
+ */
 class ProviderDoesNotExistsException extends HintException {
 
 	/**
 	 * ProviderDoesNotExistsException constructor.
 	 *
+	 * @since 14.0.0
+	 *
 	 * @param string $providerId cloud federation provider ID
 	 */
 	public function __construct($providerId) {
diff --git a/lib/public/Federation/ICloudFederationFactory.php b/lib/public/Federation/ICloudFederationFactory.php
index 8c6925c2b61..5cb4dc3106a 100644
--- a/lib/public/Federation/ICloudFederationFactory.php
+++ b/lib/public/Federation/ICloudFederationFactory.php
@@ -21,6 +21,13 @@
 
 namespace OCP\Federation;
 
+/**
+ * Interface ICloudFederationFactory
+ *
+ * @package OCP\Federation
+ *
+ * @since 14.0.0
+ */
 interface ICloudFederationFactory {
 
 	/**
diff --git a/lib/public/Federation/ICloudFederationNotification.php b/lib/public/Federation/ICloudFederationNotification.php
index c68cd7b5e4d..c7ceb6d2399 100644
--- a/lib/public/Federation/ICloudFederationNotification.php
+++ b/lib/public/Federation/ICloudFederationNotification.php
@@ -21,6 +21,13 @@
 
 namespace OCP\Federation;
 
+/**
+ * Interface ICloudFederationNotification
+ *
+ * @package OCP\Federation
+ *
+ * @since 14.0.0
+ */
 interface ICloudFederationNotification {
 
 	/**
@@ -31,7 +38,6 @@ interface ICloudFederationNotification {
 	 * @param $providerId id of the share
 	 * @param array $notification , payload of the notification
 	 *
-	 * @return
 	 * @since 14.0.0
 	 */
 	public function setMessage($notificationType, $resourceType, $providerId, array $notification);
@@ -39,7 +45,7 @@ interface ICloudFederationNotification {
 	/**
 	 * get message, ready to send out
 	 *
-	 * @return string
+	 * @return array
 	 *
 	 * @since 14.0.0
 	 */
diff --git a/lib/public/Federation/ICloudFederationShare.php b/lib/public/Federation/ICloudFederationShare.php
index b721ffb1681..fda934d9e8d 100644
--- a/lib/public/Federation/ICloudFederationShare.php
+++ b/lib/public/Federation/ICloudFederationShare.php
@@ -21,6 +21,13 @@
 
 namespace OCP\Federation;
 
+/**
+ * Interface ICloudFederationShare
+ *
+ * @package OCP\Federation
+ *
+ * @since 14.0.0
+ */
 interface ICloudFederationShare {
 
 	/**