Add visibility to all properties and move static keyword

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

7 files changed, 15 insertions, 16 deletions

diff --git a/lib/private/Files/Cache/QuerySearchHelper.php b/lib/private/Files/Cache/QuerySearchHelper.php
index 9f2d7aadd7e..f1e8aa978f4 100644
--- a/lib/private/Files/Cache/QuerySearchHelper.php
+++ b/lib/private/Files/Cache/QuerySearchHelper.php
@@ -36,7 +36,7 @@ use OCP\Files\Search\ISearchOrder;
  * Tools for transforming search queries into database queries
  */
 class QuerySearchHelper {
-	static protected $searchOperatorMap = [
+	protected static $searchOperatorMap = [
 		ISearchComparison::COMPARE_LIKE => 'iLike',
 		ISearchComparison::COMPARE_EQUAL => 'eq',
 		ISearchComparison::COMPARE_GREATER_THAN => 'gt',
@@ -45,7 +45,7 @@ class QuerySearchHelper {
 		ISearchComparison::COMPARE_LESS_THAN_EQUAL => 'lte'
 	];
 
-	static protected $searchOperatorNegativeMap = [
+	protected static $searchOperatorNegativeMap = [
 		ISearchComparison::COMPARE_LIKE => 'notLike',
 		ISearchComparison::COMPARE_EQUAL => 'neq',
 		ISearchComparison::COMPARE_GREATER_THAN => 'lte',
diff --git a/lib/private/Files/Filesystem.php b/lib/private/Files/Filesystem.php
index 1999edf67fd..248b6d2d854 100644
--- a/lib/private/Files/Filesystem.php
+++ b/lib/private/Files/Filesystem.php
@@ -80,13 +80,13 @@ class Filesystem {
 	/**
 	 * @var \OC\Files\View $defaultInstance
 	 */
-	static private $defaultInstance;
+	private static $defaultInstance;
 
-	static private $usersSetup = [];
+	private static $usersSetup = [];
 
-	static private $normalizedPathCache = null;
+	private static $normalizedPathCache = null;
 
-	static private $listeningForProviders = false;
+	private static $listeningForProviders = false;
 
 	/**
 	 * classname which used for hooks handling
diff --git a/lib/private/Search/Result/File.php b/lib/private/Search/Result/File.php
index b0f6b3df622..242bf7cb953 100644
--- a/lib/private/Search/Result/File.php
+++ b/lib/private/Search/Result/File.php
@@ -97,7 +97,7 @@ class File extends \OCP\Search\Result {
 	/**
 	 * @var Folder $userFolderCache
 	 */
-	static protected $userFolderCache = null;
+	protected static $userFolderCache = null;
 
 	/**
 	 * converts a path relative to the users files folder
diff --git a/lib/private/Setup.php b/lib/private/Setup.php
index afdc881b482..3fc8415e29a 100644
--- a/lib/private/Setup.php
+++ b/lib/private/Setup.php
@@ -105,7 +105,7 @@ class Setup {
 		$this->installer = $installer;
 	}
 
-	static protected $dbSetupClasses = [
+	protected static $dbSetupClasses = [
 		'mysql' => \OC\Setup\MySQL::class,
 		'pgsql' => \OC\Setup\PostgreSQL::class,
 		'oci' => \OC\Setup\OCI::class,
diff --git a/lib/private/legacy/OC_App.php b/lib/private/legacy/OC_App.php
index 5c06f66a20a..7b67dd3eada 100644
--- a/lib/private/legacy/OC_App.php
+++ b/lib/private/legacy/OC_App.php
@@ -65,12 +65,12 @@ use OCP\ILogger;
  * upgrading and removing apps.
  */
 class OC_App {
-	static private $adminForms = [];
-	static private $personalForms = [];
-	static private $appTypes = [];
-	static private $loadedApps = [];
-	static private $altLogin = [];
-	static private $alreadyRegistered = [];
+	private static $adminForms = [];
+	private static $personalForms = [];
+	private static $appTypes = [];
+	private static $loadedApps = [];
+	private static $altLogin = [];
+	private static $alreadyRegistered = [];
 	const supportedApp = 300;
 	const officialApp = 200;
 
diff --git a/lib/private/legacy/OC_Hook.php b/lib/private/legacy/OC_Hook.php
index fe08266fe5b..4e75c9da747 100644
--- a/lib/private/legacy/OC_Hook.php
+++ b/lib/private/legacy/OC_Hook.php
@@ -36,7 +36,7 @@
 class OC_Hook {
 	public static $thrownExceptions = [];
 
-	static private $registered = [];
+	private static $registered = [];
 
 	/**
 	 * connects a function to a hook
diff --git a/lib/private/legacy/OC_Image.php b/lib/private/legacy/OC_Image.php
index b8d3d162cc8..9ef77e3d4c6 100644
--- a/lib/private/legacy/OC_Image.php
+++ b/lib/private/legacy/OC_Image.php
@@ -1128,7 +1128,6 @@ class OC_Image implements \OCP\IImage {
 	 * @return bool
 	 */
 	public function copyResize($maxSize): IImage {
-
 	}
 
 	/**