diff options
author | Scott Dutton <scott@exussum.co.uk> | 2020-04-12 18:38:59 +0300 |
---|---|---|
committer | Morris Jobke <hey@morrisjobke.de> | 2020-08-13 23:50:38 +0300 |
commit | b12a390220a0a38ec18557b52c2eec7cf25dfc49 (patch) | |
tree | 1e4471e468b50497737dcb97c2bb64f39786d015 /tests | |
parent | e9f5c7f649b923ec45d7a37eb24369e11727ccbf (diff) |
Always try and show pre rendered preview
Currently if the following situation happens
Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)
This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.
After the fix the following would happen
Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)
This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.
Signed-off-by: Scott Dutton <scott@exussum.co.uk>
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions