diff options
author | Robin Appelman <robin@icewind.nl> | 2021-01-22 17:44:24 +0300 |
---|---|---|
committer | Robin Appelman <robin@icewind.nl> | 2021-06-04 16:42:05 +0300 |
commit | 252268e4d22f3b67219aec164fc8cbb5e04b6f92 (patch) | |
tree | 4962ef021704f2b16510706faeda8d23f0aad263 /tests | |
parent | cd4a538fa40c844954988f9843807350d3640a43 (diff) |
Set umask before operations that create local files
this solves issues where "other php stuff" is messing with the umask
Signed-off-by: Robin Appelman <robin@icewind.nl>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/lib/Files/Storage/LocalTest.php | 37 |
1 files changed, 34 insertions, 3 deletions
diff --git a/tests/lib/Files/Storage/LocalTest.php b/tests/lib/Files/Storage/LocalTest.php index 46784811248..e324d2b28db 100644 --- a/tests/lib/Files/Storage/LocalTest.php +++ b/tests/lib/Files/Storage/LocalTest.php @@ -63,21 +63,21 @@ class LocalTest extends Storage { $this->assertNotEquals($etag1, $etag2); } - + public function testInvalidArgumentsEmptyArray() { $this->expectException(\InvalidArgumentException::class); new \OC\Files\Storage\Local([]); } - + public function testInvalidArgumentsNoArray() { $this->expectException(\InvalidArgumentException::class); new \OC\Files\Storage\Local(null); } - + public function testDisallowSymlinksOutsideDatadir() { $this->expectException(\OCP\Files\ForbiddenException::class); @@ -108,4 +108,35 @@ class LocalTest extends Storage { $storage->file_put_contents('sym/foo', 'bar'); $this->addToAssertionCount(1); } + + public function testWriteUmaskFilePutContents() { + $oldMask = umask(0333); + $this->instance->file_put_contents('test.txt', 'sad'); + umask($oldMask); + $this->assertTrue($this->instance->isUpdatable('test.txt')); + } + + public function testWriteUmaskMkdir() { + $oldMask = umask(0333); + $this->instance->mkdir('test.txt'); + umask($oldMask); + $this->assertTrue($this->instance->isUpdatable('test.txt')); + } + + public function testWriteUmaskFopen() { + $oldMask = umask(0333); + $handle = $this->instance->fopen('test.txt', 'w'); + fwrite($handle, 'foo'); + fclose($handle); + umask($oldMask); + $this->assertTrue($this->instance->isUpdatable('test.txt')); + } + + public function testWriteUmaskCopy() { + $this->instance->file_put_contents('source.txt', 'sad'); + $oldMask = umask(0333); + $this->instance->copy('source.txt', 'test.txt'); + umask($oldMask); + $this->assertTrue($this->instance->isUpdatable('test.txt')); + } } |