| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.
This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.
While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.
I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
|
|
|
|
Now that OC_SubAdmin is just a wrapper around OC\SubAdmin some unit
tests had to be fixed because they expected different behaviour.
Eventually they should move to properly mocked instances of OC\SubAdmin
of course
|
|
* DI
* Tests
* moved OC_SubAdmin to legacy
* Added to private OC\GroupManager
|
|
Merge headers of ocs results
|
|
don't move files in cache twice, fixes renaming for objectstores
|
|
skip btrfs hack for objectstore docker container on btrfs host
|
|
Removemount expects absolutePath
|
|
|
|
|
|
|
|
|
|
|
|
The error message should contain the path that is being shared not the
numeric id.
|
|
|
|
|
|
|
|
IDN is not installed on all machines making the unit test execution fail on those without. Let's make IDN thus a pre-requirement for the text execution.
|
|
|
|
Fix mtime PROPPATCH to be "lastmodified" instead of "getlastmodified"
|
|
Squash collection shares
|
|
|
|
In case of an error the error message often contains sensitive data such as the full path which potentially leads to a full path disclosure.
Thus the error message should not directly get displayed to the user and instead be logged.
|
|
Fix regression that makes PROPPATCH of mtime work like it did in OC <=
8.0.
The PROPPATCH must be done on the "lastmodified" property.
The "getlastmodified" now return 403 again.
|
|
owncloud/silently-fail-app-upgrade-exceptions-master
Silently fail app upgrade exceptions
|
|
If folder1 is shared to user2 and user3. And folder1/folder2 is shared
to user4 and user5 then getting all the users with access to
folder1/folder2 should only list user2 and user 3 once.
Previously this was done twice since we request the info two times.
This fix makes sure that we only append unique results to the array.
* Added test
|
|
`\OCP\IRequest::getScriptName` will also return the directory, so if ownCloud is installed in a subfolder such as `owncloud/` it will resolve to `/owncloud/ocs/v2.php`. This made this check fail and also made it return invalid status codes.
|
|
Do not update mime types for folders with extension
|
|
|
|
Setup sendmail transport
|
|
Some folders might have an extension like "test.conf".
This fix prevents to overwrite the folder's mime type with another mime
type while running the mimetype repair step.
|
|
|
|
|
|
Prevent warning decoding content
|
|
This change makes the check return a positive result when:
- The instance has been configured to not use the internet
AND/OR
- S2S AND the appstore is disabled
|
|
Replaces https://github.com/owncloud/core/pull/19047 and fixes https://github.com/owncloud/enterprise/issues/854 and https://github.com/owncloud/core/issues/19110
|
|
Swift primary storage tests
|
|
Fix search operations for the Node API
|
|
Fixes #5251
If we perform a move we need to make sure first that the source can be
deleted. Else the dest might be cleared but the move will fail later.
* Added unit tests
Eventually we need more and better checking here.
|
|
use default config for swift primary storage test config
allow testsuite to complete
fix timeout, script cleanup, enable debug for now
use btrfs loopback device, requires privileged container and absolute path
throw exception when storage has problems
debug by echo ...
sleep more, more debug
|
|
|
|
Only allow valid HTTP protocols.
Ref https://github.com/owncloud/core/pull/19537#discussion_r41252333 + https://github.com/owncloud/security-tracker/issues/119
|
|
owncloud/share-donotreturnentrieswhenusernotingroup
Remove invalid share items from result when missing group membership
|
|
[admin] check for correct PHP memcached module
|
|
|
|
Group shares usually have subshare entries for every user. In some
situations it can happen that the user was removed from the group but
the subshare entries still exist.
This fix makes sure that such subshare entries are not returned any more
as the user isn't in the group any more.
|
|
|
