From e15b43d976691b4d0f9901650178779bdd9a5d6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 14 Jun 2022 16:07:35 +0200 Subject: Fix default toast message for failed uploads with HTTP/2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When an upload fails a toast is shown with either a specific message or just the textual part of the HTTP error code (which comes from the upload failure handler and set by "jQuery.ajax()". However, if there is neither a message nor an error then the toast will show the default message from the Toastify-js library, which is an undescriptive "Hi there!". When HTTP/2 is used Chromium does not provide the textual part of the HTTP error code, so when an upload fails the toast can receive an empty message and thus just show "Hi there!". Now an explicit message is provided as a fallback to prevent that. Signed-off-by: Daniel Calviño Sánchez --- apps/files/js/file-upload.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files/js/file-upload.js b/apps/files/js/file-upload.js index 793c9672c3f..648a5a0307b 100644 --- a/apps/files/js/file-upload.js +++ b/apps/files/js/file-upload.js @@ -1134,7 +1134,7 @@ OC.Uploader.prototype = _.extend({ } } console.error(e, data, response) - OC.Notification.show(message || data.errorThrown, {type: 'error'}); + OC.Notification.show(message || data.errorThrown || t('files', 'File could not be uploaded'), {type: 'error'}); } if (upload) { -- cgit v1.2.3