From fe47cf40da6bec69892dbfb7e78d21ab2379da02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Tue, 26 Apr 2022 09:20:59 +0200 Subject: Dashboard fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ Signed-off-by: nextcloud-command --- apps/dashboard/css/dashboard.scss | 52 -- apps/dashboard/lib/Service/BackgroundService.php | 1 + apps/dashboard/src/App.vue | 652 -------------------- apps/dashboard/src/DashboardApp.vue | 678 +++++++++++++++++++++ .../src/components/BackgroundSettings.vue | 4 - apps/dashboard/src/main.js | 4 +- 6 files changed, 681 insertions(+), 710 deletions(-) delete mode 100644 apps/dashboard/src/App.vue create mode 100644 apps/dashboard/src/DashboardApp.vue (limited to 'apps/dashboard') diff --git a/apps/dashboard/css/dashboard.scss b/apps/dashboard/css/dashboard.scss index aade857464b..f8b8ec24037 100644 --- a/apps/dashboard/css/dashboard.scss +++ b/apps/dashboard/css/dashboard.scss @@ -54,55 +54,3 @@ #appmenu li a:focus::before { display: none !important; } - -$has-custom-logo: variable_exists('theming-logo-mime') and $theming-logo-mime != ''; - -body.dashboard--inverted:not(.dashboard--dark) { - // Do not invert the default logo - @if ($has-custom-logo == false) { - $image-logo: url(icon-color-path('logo', 'logo', #ffffff, 1, true)); - #header .logo { - background-image: $image-logo !important; - opacity: 1; - } - } - - #app-dashboard > h2 { - color: #fff; - } - #appmenu li span { - color: #fff; - } - #appmenu svg image { - filter: invert(0); - } - #appmenu .icon-more-white, - .header-right > div:not(#settings) > *:first-child { - filter: invert(1) hue-rotate(180deg); - } -} - -body.dashboard--dark:not(.dashboard--inverted) { - // invert the default logo - @if ($has-custom-logo == false) { - $image-logo: url(icon-color-path('logo', 'logo', #000000, 1, true)); - #header .logo { - background-image: $image-logo !important; - opacity: 1; - } - } - - #app-dashboard > h2 { - color: #000; - } - #appmenu li span { - color: #000; - } - #appmenu svg { - filter: invert(1) hue-rotate(180deg) !important; - } - #appmenu .icon-more-white, - .header-right > div:not(#settings) > *:first-child { - filter: invert(1) hue-rotate(180deg) !important; - } -} diff --git a/apps/dashboard/lib/Service/BackgroundService.php b/apps/dashboard/lib/Service/BackgroundService.php index f9bd987bdca..13ad03cf860 100644 --- a/apps/dashboard/lib/Service/BackgroundService.php +++ b/apps/dashboard/lib/Service/BackgroundService.php @@ -40,6 +40,7 @@ use OCP\Lock\LockedException; use OCP\PreConditionNotMetException; class BackgroundService { + // true when the background is bright and need dark icons public const THEMING_MODE_DARK = 'dark'; public const SHIPPED_BACKGROUNDS = [ diff --git a/apps/dashboard/src/App.vue b/apps/dashboard/src/App.vue deleted file mode 100644 index e8a1933287a..00000000000 --- a/apps/dashboard/src/App.vue +++ /dev/null @@ -1,652 +0,0 @@ - - - - - diff --git a/apps/dashboard/src/DashboardApp.vue b/apps/dashboard/src/DashboardApp.vue new file mode 100644 index 00000000000..46de7b58827 --- /dev/null +++ b/apps/dashboard/src/DashboardApp.vue @@ -0,0 +1,678 @@ + + + + + diff --git a/apps/dashboard/src/components/BackgroundSettings.vue b/apps/dashboard/src/components/BackgroundSettings.vue index 691ce12cfd3..bd2154e89a7 100644 --- a/apps/dashboard/src/components/BackgroundSettings.vue +++ b/apps/dashboard/src/components/BackgroundSettings.vue @@ -181,10 +181,6 @@ export default { content: ''; display: block; height: 100%; - - body.theme--dark & { - background-image: var(--icon-checkmark-000); - } } } } diff --git a/apps/dashboard/src/main.js b/apps/dashboard/src/main.js index 0640691b283..dc276959b11 100644 --- a/apps/dashboard/src/main.js +++ b/apps/dashboard/src/main.js @@ -21,7 +21,7 @@ */ import Vue from 'vue' -import App from './App.vue' +import DashboardApp from './DashboardApp.vue' import { translate as t } from '@nextcloud/l10n' import VTooltip from '@nextcloud/vue/dist/Directives/Tooltip' import { getRequestToken } from '@nextcloud/auth' @@ -40,7 +40,7 @@ if (!window.OCA.Files) { Object.assign(window.OCA.Files, { App: { fileList: { filesClient: OC.Files.getClient() } } }, window.OCA.Files) -const Dashboard = Vue.extend(App) +const Dashboard = Vue.extend(DashboardApp) const Instance = new Dashboard({}).$mount('#app-content-vue') window.OCA.Dashboard = { -- cgit v1.2.3