From cf9b1082ed4550d3ece15d1c2cc613a0a5e008bc Mon Sep 17 00:00:00 2001 From: szaimen Date: Mon, 11 Jul 2022 16:46:31 +0200 Subject: add a setup check for 64 bit Signed-off-by: szaimen --- apps/settings/lib/Controller/CheckSetupController.php | 9 +++++++++ apps/settings/tests/Controller/CheckSetupControllerTest.php | 7 +++++++ 2 files changed, 16 insertions(+) (limited to 'apps/settings') diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index 51027c5ad1c..8f469c6c4e9 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -747,6 +747,14 @@ Raw output return true; } + protected function is64bit(): bool { + if (PHP_INT_SIZE < 8) { + return false; + } else { + return true; + } + } + protected function isMysqlUsedWithoutUTF8MB4(): bool { return ($this->config->getSystemValue('dbtype', 'sqlite') === 'mysql') && ($this->config->getSystemValue('mysql.utf8mb4', false) === false); } @@ -880,6 +888,7 @@ Raw output 'appDirsWithDifferentOwner' => $this->getAppDirsWithDifferentOwner(), 'isImagickEnabled' => $this->isImagickEnabled(), 'areWebauthnExtensionsEnabled' => $this->areWebauthnExtensionsEnabled(), + 'is64bit' => $this->is64bit(), 'recommendedPHPModules' => $this->hasRecommendedPHPModules(), 'pendingBigIntConversionColumns' => $this->hasBigIntConversionPendingColumns(), 'isMysqlUsedWithoutUTF8MB4' => $this->isMysqlUsedWithoutUTF8MB4(), diff --git a/apps/settings/tests/Controller/CheckSetupControllerTest.php b/apps/settings/tests/Controller/CheckSetupControllerTest.php index 8c9b2f216af..c109bad04ff 100644 --- a/apps/settings/tests/Controller/CheckSetupControllerTest.php +++ b/apps/settings/tests/Controller/CheckSetupControllerTest.php @@ -199,6 +199,7 @@ class CheckSetupControllerTest extends TestCase { 'getAppDirsWithDifferentOwner', 'isImagickEnabled', 'areWebauthnExtensionsEnabled', + 'is64bit', 'hasRecommendedPHPModules', 'hasBigIntConversionPendingColumns', 'isMysqlUsedWithoutUTF8MB4', @@ -536,6 +537,11 @@ class CheckSetupControllerTest extends TestCase { ->method('areWebauthnExtensionsEnabled') ->willReturn(false); + $this->checkSetupController + ->expects($this->once()) + ->method('is64bit') + ->willReturn(false); + $this->checkSetupController ->expects($this->once()) ->method('hasRecommendedPHPModules') @@ -632,6 +638,7 @@ class CheckSetupControllerTest extends TestCase { 'appDirsWithDifferentOwner' => [], 'isImagickEnabled' => false, 'areWebauthnExtensionsEnabled' => false, + 'is64bit' => false, 'recommendedPHPModules' => [], 'pendingBigIntConversionColumns' => [], 'isMysqlUsedWithoutUTF8MB4' => false, -- cgit v1.2.3