From 47a0254bb372cf68626302175d2e5f9d0c10e73b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Wed, 31 Jul 2019 10:05:46 +0200 Subject: Validate urls in theming settings and properly handle error messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- apps/theming/js/settings-admin.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'apps/theming/js') diff --git a/apps/theming/js/settings-admin.js b/apps/theming/js/settings-admin.js index af9c584265c..81b10bcc08e 100644 --- a/apps/theming/js/settings-admin.js +++ b/apps/theming/js/settings-admin.js @@ -32,7 +32,7 @@ function setThemingValue(setting, value) { hideUndoButton(setting, value); preview(setting, value, response.data.serverCssUrl); }).fail(function(response) { - OC.msg.finishedSaving('#theming_settings_msg', response); + OC.msg.finishedSaving('#theming_settings_msg', response.responseJSON); $('#theming_settings_loading').hide(); }); } @@ -159,7 +159,7 @@ $(document).ready(function () { return true; } else { throw t('theming', 'Name cannot be empty'); - } + } } catch (error) { $('#theming-name').attr('title', error); $('#theming-name').tooltip({placement: 'top', trigger: 'manual'}); @@ -174,7 +174,7 @@ $(document).ready(function () { if (checkName()) { $('#theming-name').tooltip('hide'); $('#theming-name').removeClass('error'); - } + } }); $('#theming-name').change(function(e) { -- cgit v1.2.3