From 0b58b0faf3f6aba4ec78935e21d4201048ccfcc9 Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Sat, 2 Feb 2019 18:07:48 +0100 Subject: Do not run getRepairSteps in register_commands getRepairSteps is quite expensive (because every repair step is initialized and their dependencies are injected). Should not call it during register. Signed-off-by: Daniel Kesselberg --- core/Command/Maintenance/Repair.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'core/Command/Maintenance') diff --git a/core/Command/Maintenance/Repair.php b/core/Command/Maintenance/Repair.php index 71d13cd29f3..e9595a22285 100644 --- a/core/Command/Maintenance/Repair.php +++ b/core/Command/Maintenance/Repair.php @@ -77,11 +77,14 @@ class Repair extends Command { } protected function execute(InputInterface $input, OutputInterface $output) { - $includeExpensive = $input->getOption('include-expensive'); - if ($includeExpensive) { - foreach ($this->repair->getExpensiveRepairSteps() as $step) { - $this->repair->addStep($step); - } + $repairSteps = $this->repair::getRepairSteps(); + + if ($input->getOption('include-expensive')) { + $repairSteps = array_merge($repairSteps, $this->repair::getExpensiveRepairSteps()); + } + + foreach ($repairSteps as $step) { + $this->repair->addStep($step); } $apps = $this->appManager->getInstalledApps(); -- cgit v1.2.3