From d9aae20003eb670b7bf86708016473969088066a Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <JanCBorchardt@fsfe.org>
Date: Sat, 20 Aug 2011 05:07:58 +0200
Subject: more valid HTML, alt attributes, refactored pagenavi etc.

---
 settings/js/users.js         |  6 +++---
 settings/templates/apps.php  |  2 +-
 settings/templates/help.php  |  6 +++---
 settings/templates/users.php | 13 ++++++++-----
 4 files changed, 15 insertions(+), 12 deletions(-)

(limited to 'settings')

diff --git a/settings/js/users.js b/settings/js/users.js
index 3122f5614c7..0570263d300 100644
--- a/settings/js/users.js
+++ b/settings/js/users.js
@@ -131,7 +131,7 @@ $(document).ready(function(){
 				
 			}
 		);
-		var tr=$('#content table tr').first().next().clone();
+		var tr=$('#content table tbody tr').first().clone();
 		tr.attr('data-uid',username);
 		tr.find('td.name').text(username);
 		var select=$('<select multiple="multiple" data-placehoder="Groups" title="Groups">');
@@ -142,10 +142,10 @@ $(document).ready(function(){
 			select.append($('<option value="'+group+'">'+group+'</option>'));
 		});
 		tr.find('td.groups').append(select);
-		if(tr.find('td.remve img').length==0){
+		if(tr.find('td.remove img').length==0){
 			tr.find('td.remove').append($('<img alt="Delete" title="'+t('settings','Delete')+'" class="svg action" src="'+OC.imagePath('core','actions/delete')+'"/>'));
 		}
 		applyMultiplySelect(select);
-		$('#content table tr').last().after(tr);
+		$('#content table tbody').last().after(tr);
 	});
 });
diff --git a/settings/templates/apps.php b/settings/templates/apps.php
index 025fbc4c81f..d5375c06fc4 100644
--- a/settings/templates/apps.php
+++ b/settings/templates/apps.php
@@ -12,5 +12,5 @@
 	<h3><strong><span class="name"><?php echo $l->t('Select an App');?></span></strong><span class="version"></span></h3>
 	<p class="description"></p>
 	<p class="hidden"><span class="licence"></span><?php echo $l->t('-licensed');?> <?php echo $l->t('by');?> <span class="author"></span></p>
-	<input class="enable hidden" type="submit"></input>
+	<input class="enable hidden" type="submit" />
 </div>
diff --git a/settings/templates/help.php b/settings/templates/help.php
index 31f6101c1ef..d44438add9b 100644
--- a/settings/templates/help.php
+++ b/settings/templates/help.php
@@ -1,13 +1,13 @@
 <?php if(is_null($_["kbe"])):?>
 	<div class="personalblock">
-		<p><?php echo $l->t('Problems connecting to help database.');?>
-		<a href="http://apps.owncloud.com/kb"><?php echo $l->t('Go there manually.');?></a>
+		<p><?php echo $l->t('Problems connecting to help database.');?></p>
+		<p><a href="http://apps.owncloud.com/kb"><?php echo $l->t('Go there manually.');?></a></p>
 	</div>
 <?php else:?>
 	<?php foreach($_["kbe"] as $kb): ?>
 	<div class="personalblock">
 		<?php if($kb["preview1"] <> "") { echo('<img class="preview" src="'.$kb["preview1"].'" />'); } ?>
-		<p><strong><?php if($kb['detailpage']<>'') echo('<p><a target="_blank" href="'.$kb['detailpage'].'"><strong>'.$kb["name"].'</strong></a></p>');?></strong></p>
+		<?php if($kb['detailpage']<>'') echo('<p><a target="_blank" href="'.$kb['detailpage'].'"><strong>'.$kb["name"].'</strong></a></p>');?>
 		<p><?php echo $kb['description'];?></p>
 		<?php if($kb['answer']<>'') echo('<p><strong>'.$l->t('Answer').':</strong><p>'.$kb['answer'].'</p>');?>
 	</div>
diff --git a/settings/templates/users.php b/settings/templates/users.php
index 9733c3e9a50..244f3632931 100644
--- a/settings/templates/users.php
+++ b/settings/templates/users.php
@@ -6,17 +6,20 @@ foreach($_["groups"] as $group) {
 ?>
 
 <table data-groups="<?php echo implode(', ',$allGroups);?>">
-	<tbody>
-		<tr id="controls"><form id="newuser">
-			<th class="name"><input id="newusername" placeholder="<?php echo $l->t('Name')?>"></input></th>
-			<th class="password"><input type="password" id="newuserpassword" placeholder="<?php echo $l->t('Password')?>"></input></th>
+	<thead id="controls">
+		<tr><form id="newuser">
+			<th class="name"><input id="newusername" placeholder="<?php echo $l->t('Name')?>" /></th>
+			<th class="password"><input type="password" id="newuserpassword" placeholder="<?php echo $l->t('Password')?>" /></th>
 			<th class="groups"><select id="newusergroups" data-placeholder="groups" title="<?php echo $l->t('Groups')?>" multiple="multiple">
 			<?php foreach($_["groups"] as $group): ?>
 				<option value="<?php echo $group['name'];?>"><?php echo $group['name'];?></option>
 			<?php endforeach;?>
 			</select></th>
-			<th><input type="submit" value="<?php echo $l->t('Create')?>"></input></th>
+			<th class="quota"></th>
+			<th><input type="submit" value="<?php echo $l->t('Create')?>" /></th>
 		</form></tr>
+	</thead>
+	<tbody>
 	<?php foreach($_["users"] as $user): ?>
 		<tr data-uid="<?php echo $user["name"] ?>">
 			<td class="name"><?php echo $user["name"]; ?></td>
-- 
cgit v1.2.3