1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
|
<?php
/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
* @author Joas Schilling <coding@schilljs.com>
* @author Morris Jobke <hey@morrisjobke.de>
* @author Robin Appelman <robin@icewind.nl>
* @author Thomas Müller <thomas.mueller@tmit.eu>
* @author Vincent Petry <pvince81@owncloud.com>
*
* @license AGPL-3.0
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
namespace OCA\DAV\Tests\Unit\Connector\Sabre;
use OC\Files\FileInfo;
use OC\Files\Storage\Wrapper\Quota;
use OCA\DAV\Connector\Sabre\Directory;
use OCP\Files\ForbiddenException;
class TestViewDirectory extends \OC\Files\View {
private $updatables;
private $deletables;
private $canRename;
public function __construct($updatables, $deletables, $canRename = true) {
$this->updatables = $updatables;
$this->deletables = $deletables;
$this->canRename = $canRename;
}
public function isUpdatable($path) {
return $this->updatables[$path];
}
public function isCreatable($path) {
return $this->updatables[$path];
}
public function isDeletable($path) {
return $this->deletables[$path];
}
public function rename($path1, $path2) {
return $this->canRename;
}
public function getRelativePath($path) {
return $path;
}
}
/**
* @group DB
*/
class DirectoryTest extends \Test\TestCase {
/** @var \OC\Files\View | \PHPUnit_Framework_MockObject_MockObject */
private $view;
/** @var \OC\Files\FileInfo | \PHPUnit_Framework_MockObject_MockObject */
private $info;
protected function setUp(): void {
parent::setUp();
$this->view = $this->createMock('OC\Files\View');
$this->info = $this->createMock('OC\Files\FileInfo');
$this->info->expects($this->any())
->method('isReadable')
->willReturn(true);
}
private function getDir($path = '/') {
$this->view->expects($this->once())
->method('getRelativePath')
->will($this->returnValue($path));
$this->info->expects($this->once())
->method('getPath')
->will($this->returnValue($path));
return new Directory($this->view, $this->info);
}
/**
* @expectedException \Sabre\DAV\Exception\Forbidden
*/
public function testDeleteRootFolderFails() {
$this->info->expects($this->any())
->method('isDeletable')
->will($this->returnValue(true));
$this->view->expects($this->never())
->method('rmdir');
$dir = $this->getDir();
$dir->delete();
}
/**
* @expectedException \OCA\DAV\Connector\Sabre\Exception\Forbidden
*/
public function testDeleteForbidden() {
// deletion allowed
$this->info->expects($this->once())
->method('isDeletable')
->will($this->returnValue(true));
// but fails
$this->view->expects($this->once())
->method('rmdir')
->with('sub')
->willThrowException(new ForbiddenException('', true));
$dir = $this->getDir('sub');
$dir->delete();
}
/**
*
*/
public function testDeleteFolderWhenAllowed() {
// deletion allowed
$this->info->expects($this->once())
->method('isDeletable')
->will($this->returnValue(true));
// but fails
$this->view->expects($this->once())
->method('rmdir')
->with('sub')
->will($this->returnValue(true));
$dir = $this->getDir('sub');
$dir->delete();
}
/**
* @expectedException \Sabre\DAV\Exception\Forbidden
*/
public function testDeleteFolderFailsWhenNotAllowed() {
$this->info->expects($this->once())
->method('isDeletable')
->will($this->returnValue(false));
$dir = $this->getDir('sub');
$dir->delete();
}
/**
* @expectedException \Sabre\DAV\Exception\Forbidden
*/
public function testDeleteFolderThrowsWhenDeletionFailed() {
// deletion allowed
$this->info->expects($this->once())
->method('isDeletable')
->will($this->returnValue(true));
// but fails
$this->view->expects($this->once())
->method('rmdir')
->with('sub')
->will($this->returnValue(false));
$dir = $this->getDir('sub');
$dir->delete();
}
public function testGetChildren() {
$info1 = $this->getMockBuilder(FileInfo::class)
->disableOriginalConstructor()
->getMock();
$info2 = $this->getMockBuilder(FileInfo::class)
->disableOriginalConstructor()
->getMock();
$info1->expects($this->any())
->method('getName')
->will($this->returnValue('first'));
$info1->expects($this->any())
->method('getEtag')
->will($this->returnValue('abc'));
$info2->expects($this->any())
->method('getName')
->will($this->returnValue('second'));
$info2->expects($this->any())
->method('getEtag')
->will($this->returnValue('def'));
$this->view->expects($this->once())
->method('getDirectoryContent')
->with('')
->will($this->returnValue(array($info1, $info2)));
$this->view->expects($this->any())
->method('getRelativePath')
->will($this->returnValue(''));
$dir = new Directory($this->view, $this->info);
$nodes = $dir->getChildren();
$this->assertEquals(2, count($nodes));
// calling a second time just returns the cached values,
// does not call getDirectoryContents again
$dir->getChildren();
}
/**
* @expectedException \Sabre\DAV\Exception\Forbidden
*/
public function testGetChildrenNoPermission() {
$info = $this->createMock(FileInfo::class);
$info->expects($this->any())
->method('isReadable')
->will($this->returnValue(false));
$dir = new Directory($this->view, $info);
$dir->getChildren();
}
/**
* @expectedException \Sabre\DAV\Exception\NotFound
*/
public function testGetChildNoPermission() {
$this->info->expects($this->any())
->method('isReadable')
->will($this->returnValue(false));
$dir = new Directory($this->view, $this->info);
$dir->getChild('test');
}
/**
* @expectedException \Sabre\DAV\Exception\ServiceUnavailable
*/
public function testGetChildThrowStorageNotAvailableException() {
$this->view->expects($this->once())
->method('getFileInfo')
->willThrowException(new \OCP\Files\StorageNotAvailableException());
$dir = new Directory($this->view, $this->info);
$dir->getChild('.');
}
/**
* @expectedException \OCA\DAV\Connector\Sabre\Exception\InvalidPath
*/
public function testGetChildThrowInvalidPath() {
$this->view->expects($this->once())
->method('verifyPath')
->willThrowException(new \OCP\Files\InvalidPathException());
$this->view->expects($this->never())
->method('getFileInfo');
$dir = new Directory($this->view, $this->info);
$dir->getChild('.');
}
public function testGetQuotaInfoUnlimited() {
$storage = $this->getMockBuilder(Quota::class)
->disableOriginalConstructor()
->getMock();
$storage->expects($this->any())
->method('instanceOfStorage')
->will($this->returnValueMap([
'\OCA\Files_Sharing\SharedStorage' => false,
'\OC\Files\Storage\Wrapper\Quota' => false,
]));
$storage->expects($this->never())
->method('getQuota');
$storage->expects($this->once())
->method('free_space')
->will($this->returnValue(800));
$this->info->expects($this->once())
->method('getSize')
->will($this->returnValue(200));
$this->info->expects($this->once())
->method('getStorage')
->will($this->returnValue($storage));
$dir = new Directory($this->view, $this->info);
$this->assertEquals([200, -3], $dir->getQuotaInfo()); //200 used, unlimited
}
public function testGetQuotaInfoSpecific() {
$storage = $this->getMockBuilder(Quota::class)
->disableOriginalConstructor()
->getMock();
$storage->expects($this->any())
->method('instanceOfStorage')
->will($this->returnValueMap([
['\OCA\Files_Sharing\SharedStorage', false],
['\OC\Files\Storage\Wrapper\Quota', true],
]));
$storage->expects($this->once())
->method('getQuota')
->will($this->returnValue(1000));
$storage->expects($this->once())
->method('free_space')
->will($this->returnValue(800));
$this->info->expects($this->once())
->method('getSize')
->will($this->returnValue(200));
$this->info->expects($this->once())
->method('getStorage')
->will($this->returnValue($storage));
$dir = new Directory($this->view, $this->info);
$this->assertEquals([200, 800], $dir->getQuotaInfo()); //200 used, 800 free
}
/**
* @dataProvider moveFailedProvider
* @expectedException \Sabre\DAV\Exception\Forbidden
*/
public function testMoveFailed($source, $destination, $updatables, $deletables) {
$this->moveTest($source, $destination, $updatables, $deletables);
}
/**
* @dataProvider moveSuccessProvider
*/
public function testMoveSuccess($source, $destination, $updatables, $deletables) {
$this->moveTest($source, $destination, $updatables, $deletables);
$this->addToAssertionCount(1);
}
/**
* @dataProvider moveFailedInvalidCharsProvider
* @expectedException \OCA\DAV\Connector\Sabre\Exception\InvalidPath
*/
public function testMoveFailedInvalidChars($source, $destination, $updatables, $deletables) {
$this->moveTest($source, $destination, $updatables, $deletables);
}
public function moveFailedInvalidCharsProvider() {
return [
['a/b', 'a/*', ['a' => true, 'a/b' => true, 'a/c*' => false], []],
];
}
public function moveFailedProvider() {
return [
['a/b', 'a/c', ['a' => false, 'a/b' => false, 'a/c' => false], []],
['a/b', 'b/b', ['a' => false, 'a/b' => false, 'b' => false, 'b/b' => false], []],
['a/b', 'b/b', ['a' => false, 'a/b' => true, 'b' => false, 'b/b' => false], []],
['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => false, 'b/b' => false], []],
['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => false]],
['a/b', 'a/c', ['a' => false, 'a/b' => true, 'a/c' => false], []],
];
}
public function moveSuccessProvider() {
return [
['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => true]],
// older files with special chars can still be renamed to valid names
['a/b*', 'b/b', ['a' => true, 'a/b*' => true, 'b' => true, 'b/b' => false], ['a/b*' => true]],
];
}
/**
* @param $source
* @param $destination
* @param $updatables
*/
private function moveTest($source, $destination, $updatables, $deletables) {
$view = new TestViewDirectory($updatables, $deletables);
$sourceInfo = new FileInfo($source, null, null, [], null);
$targetInfo = new FileInfo(dirname($destination), null, null, [], null);
$sourceNode = new Directory($view, $sourceInfo);
$targetNode = $this->getMockBuilder(Directory::class)
->setMethods(['childExists'])
->setConstructorArgs([$view, $targetInfo])
->getMock();
$targetNode->expects($this->any())->method('childExists')
->with(basename($destination))
->willReturn(false);
$this->assertTrue($targetNode->moveInto(basename($destination), $source, $sourceNode));
}
/**
* @expectedException \Sabre\DAV\Exception\Forbidden
* @expectedExceptionMessage Could not copy directory b, target exists
*/
public function testFailingMove() {
$source = 'a/b';
$destination = 'c/b';
$updatables = ['a' => true, 'a/b' => true, 'b' => true, 'c/b' => false];
$deletables = ['a/b' => true];
$view = new TestViewDirectory($updatables, $deletables);
$sourceInfo = new FileInfo($source, null, null, [], null);
$targetInfo = new FileInfo(dirname($destination), null, null, [], null);
$sourceNode = new Directory($view, $sourceInfo);
$targetNode = $this->getMockBuilder(Directory::class)
->setMethods(['childExists'])
->setConstructorArgs([$view, $targetInfo])
->getMock();
$targetNode->expects($this->once())->method('childExists')
->with(basename($destination))
->willReturn(true);
$targetNode->moveInto(basename($destination), $source, $sourceNode);
}
}
|