diff options
author | Marco <marcoambrosini@pm.me> | 2022-04-29 12:11:52 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-29 12:11:52 +0300 |
commit | 424b79a7b82414bfcffdb884bb022dd4a4ec468d (patch) | |
tree | 149265ed16e35941a03aa7a319671bc183658a10 | |
parent | 2214a041231bd36fa56f9fed2efa29272404e2a0 (diff) | |
parent | 4bfc3a530e96956f451cd2a6c97ec903f6c4ed58 (diff) |
Merge pull request #7241 from nextcloud/bugfix/7224/use-a-normal-link-and-open-in-new-tab-by-default
Use a normal link and open in new tab by default
-rw-r--r-- | src/components/SettingsDialog/SettingsDialog.vue | 27 |
1 files changed, 10 insertions, 17 deletions
diff --git a/src/components/SettingsDialog/SettingsDialog.vue b/src/components/SettingsDialog/SettingsDialog.vue index 12a8f85f6..e5f695f36 100644 --- a/src/components/SettingsDialog/SettingsDialog.vue +++ b/src/components/SettingsDialog/SettingsDialog.vue @@ -63,15 +63,12 @@ <label for="play_sounds">{{ t('spreed', 'Play sounds when participants join or leave a call') }}</label> <em>{{ t('spreed', 'Sounds can currently not be played in Safari browser and iPad and iPhone devices due to technical restrictions by the manufacturer.') }}</em> - <Button type="tertiary" - @click="goToPersonalSettings"> - <template #icon> - <OpenInNew :size="20" - decorative - title="" /> - </template> - {{ t('spreed', 'Sounds for chat and call notifications can be adjusted in the personal settings.') }} - </Button> + <a :href="settingsUrl" + target="_blank" + rel="noreferrer nofollow" + class="external"> + {{ t('spreed', 'Sounds for chat and call notifications can be adjusted in the personal settings.') }} ↗ + </a> </AppSettingsSection> <AppSettingsSection :title="t('spreed', 'Keyboard shortcuts')"> <em>{{ t('spreed', 'Speed up your Talk experience with these quick shortcuts.') }}</em> @@ -142,9 +139,7 @@ import { subscribe, unsubscribe } from '@nextcloud/event-bus' import MediaDevicesPreview from '../MediaDevicesPreview' import AppSettingsDialog from '@nextcloud/vue/dist/Components/AppSettingsDialog' import AppSettingsSection from '@nextcloud/vue/dist/Components/AppSettingsSection' -import Button from '@nextcloud/vue/dist/Components/Button' import CheckboxRadioSwitch from '@nextcloud/vue/dist/Components/CheckboxRadioSwitch' -import OpenInNew from 'vue-material-design-icons/OpenInNew' export default { name: 'SettingsDialog', @@ -153,9 +148,7 @@ export default { MediaDevicesPreview, AppSettingsDialog, AppSettingsSection, - Button, CheckboxRadioSwitch, - OpenInNew, }, data() { @@ -195,6 +188,10 @@ export default { readStatusPrivacy() { return this.$store.getters.getReadStatusPrivacy() }, + + settingsUrl() { + return generateUrl('/settings/user/notifications') + }, }, mounted() { @@ -266,10 +263,6 @@ export default { beforeDestroy() { unsubscribe('show-settings', this.handleShowSettings) }, - - goToPersonalSettings() { - window.location = generateUrl('/settings/user/notifications') - }, }, } </script> |