diff options
author | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2019-12-05 17:39:24 +0300 |
---|---|---|
committer | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2019-12-06 08:06:07 +0300 |
commit | ad543b43db7e753c302ba746379cfff72314e72d (patch) | |
tree | 758c60052f24a5298f00b7a97b955ba36ab364ac | |
parent | e3d8b4712b97f6224673ed353d5c4ee4cc6876c8 (diff) |
Move promotion of new speaker into "add" function
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
-rw-r--r-- | js/webrtc.js | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/js/webrtc.js b/js/webrtc.js index 2bf25ccc2..5cd944733 100644 --- a/js/webrtc.js +++ b/js/webrtc.js @@ -661,12 +661,20 @@ var spreedPeerConnectionTable = []; videoView.$el.after(videoView.newDummyVideoContainer()); } }, - add: function(id, notPromote) { + add: function(id) { if (!(typeof id === 'string' || id instanceof String)) { return; } - if (notPromote) { + var otherSpeakerPromoted = false; + for (var key in spreedListofSpeakers) { + if (spreedListofSpeakers.hasOwnProperty(key) && spreedListofSpeakers[key] > 1) { + otherSpeakerPromoted = true; + break; + } + } + + if (otherSpeakerPromoted) { spreedListofSpeakers[id] = 1; return; } @@ -1108,18 +1116,7 @@ var spreedPeerConnectionTable = []; return; } - var otherSpeakerPromoted = false; - for (var key in spreedListofSpeakers) { - if (spreedListofSpeakers.hasOwnProperty(key) && spreedListofSpeakers[key] > 1) { - otherSpeakerPromoted = true; - break; - } - } - if (!otherSpeakerPromoted) { - OCA.SpreedMe.speakers.add(peer.id); - } else { - OCA.SpreedMe.speakers.add(peer.id, true); - } + OCA.SpreedMe.speakers.add(peer.id); }); OCA.SpreedMe.webrtc.on('speaking', function(){ |