check if binary has correct owner and permissions

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

1 files changed, 10 insertions, 3 deletions

diff --git a/lib/Controller/MatterbridgeSettingsController.php b/lib/Controller/MatterbridgeSettingsController.php
index 0c0a8a77e..f1882c783 100644
--- a/lib/Controller/MatterbridgeSettingsController.php
+++ b/lib/Controller/MatterbridgeSettingsController.php
@@ -27,6 +27,7 @@ namespace OCA\Talk\Controller;
 
 use OCA\Talk\MatterbridgeManager;
 use OCA\Talk\Exceptions\ImpossibleToKillException;
+use OCA\Talk\Exceptions\WrongPermissionsException;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
@@ -49,10 +50,16 @@ class MatterbridgeSettingsController extends OCSController {
 	 * @return DataResponse
 	 */
 	public function getMatterbridgeVersion(): DataResponse {
-		$version = $this->bridgeManager->getCurrentVersionFromBinary();
-		if ($version === null) {
+		try {
+			$version = $this->bridgeManager->getCurrentVersionFromBinary();
+			if ($version === null) {
+				return new DataResponse([
+					'error' => 'binary',
+				], Http::STATUS_BAD_REQUEST);
+			}
+		} catch (WrongPermissionsException $e) {
 			return new DataResponse([
-				'error' => 'binary',
+				'error' => 'binary_permissions',
 			], Http::STATUS_BAD_REQUEST);
 		}