Adjustments for listable rooms after review

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

1 files changed, 8 insertions, 4 deletions

diff --git a/lib/Room.php b/lib/Room.php
index 7a3cf2885..e371631c5 100644
--- a/lib/Room.php
+++ b/lib/Room.php
@@ -65,10 +65,10 @@ class Room {
 	/**
 	 * Only visible when joined
 	 */
-	public const LISTABLE_PARTICIPANTS = 0;
+	public const LISTABLE_NONE = 0;
 
 	/**
-	 * Searchable by all regular users and moderators, even when not joined, excluding guest users
+	 * Searchable by all regular users and moderators, even when not joined, excluding users from the guest app
 	 */
 	public const LISTABLE_USERS = 1;
 
@@ -818,11 +818,15 @@ class Room {
 			return true;
 		}
 
-		if (!in_array($this->getType(), [self::GROUP_CALL, self::PUBLIC_CALL, self::CHANGELOG_CONVERSATION], true)) {
+		if (!in_array($this->getType(), [self::GROUP_CALL, self::PUBLIC_CALL], true)) {
 			return false;
 		}
 
-		if ($newState < 0 || $newState > 3) {
+		if (!in_array($newState, [
+			Room::LISTABLE_NONE,
+			Room::LISTABLE_USERS,
+			Room::LISTABLE_ALL,
+		], true)) {
 			return false;
 		}