diff options
| author | Vincent Petry <vincent@nextcloud.com> | 2020-12-04 12:33:23 +0300 |
|---|---|---|
| committer | Vincent Petry <vincent@nextcloud.com> | 2020-12-11 20:15:50 +0300 |
| commit | 0aa0dcfd3e78855691513a974e3f7326a197136e (patch) | |
| tree | 23433c6e1dd89d084ee590bd55e9fb6a6f948f63 /tests | |
| parent | 89f05b44a41648fba6fdf58613dae5f678997d31 (diff) | |
Apply suggestions from code review of listable rooms feature
Always join as USER when joining group or public room
Allow nulls for Oracle
Changes after review
Removed populateBaseRoomData and reused the existing code by adding an
extra condition for when querying listable rooms with null participant.
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/integration/features/bootstrap/FeatureContext.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/integration/features/bootstrap/FeatureContext.php b/tests/integration/features/bootstrap/FeatureContext.php index 923737e65..03c6cc171 100644 --- a/tests/integration/features/bootstrap/FeatureContext.php +++ b/tests/integration/features/bootstrap/FeatureContext.php @@ -798,7 +798,7 @@ class FeatureContext implements Context, SnippetAcceptingContext { } /** - * @Then /^user "([^"]*)" allows listing room "([^"]*)" for "(joined|users|all)" with (\d+)(?: \((v(1|2|3))\))?$/ + * @Then /^user "([^"]*)" allows listing room "([^"]*)" for "(none|users|all)" with (\d+)(?: \((v(1|2|3))\))?$/ * * @param string $user * @param string $newState @@ -808,7 +808,7 @@ class FeatureContext implements Context, SnippetAcceptingContext { */ public function userChangesListableScopeOfTheRoom($user, $identifier, $newState, $statusCode, $apiVersion = 'v3') { $this->setCurrentUser($user); - if ($newState === 'joined') { + if ($newState === 'none') { $newStateValue = Room::LISTABLE_NONE; } elseif ($newState === 'users') { $newStateValue = Room::LISTABLE_USERS; |