From bf5f57348d1d071336b5d3723a2460d5dd01fe1b Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Mon, 25 Mar 2019 09:32:17 +0100 Subject: Wait for load of script before binding Signed-off-by: Roeland Jago Douma --- jquery.strengthify.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/jquery.strengthify.js b/jquery.strengthify.js index 3a41568..6623fd2 100644 --- a/jquery.strengthify.js +++ b/jquery.strengthify.js @@ -214,9 +214,12 @@ if (options.nonce !== null) { script.setAttribute('nonce', options.nonce); } - document.head.appendChild(script); - $elem.bind('keyup input change', drawSelf); + script.onload = function() { + $elem.bind('keyup input change', drawSelf); + } + + document.head.appendChild(script); }; init.call(this); -- cgit v1.2.3 From d4ee6076cc99cb9b6541b73c8bb6b1a1578aad43 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Mon, 25 Mar 2019 09:36:44 +0100 Subject: Also move other drawSelf bind to onload Signed-off-by: Roeland Jago Douma --- jquery.strengthify.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/jquery.strengthify.js b/jquery.strengthify.js index 6623fd2..b003d8b 100644 --- a/jquery.strengthify.js +++ b/jquery.strengthify.js @@ -207,8 +207,6 @@ getWrapperFor(elemId).append('
'); } - $elem.parent().on('scroll', drawSelf); - var script = document.createElement("script"); script.src = options.zxcvbn; if (options.nonce !== null) { @@ -216,6 +214,7 @@ } script.onload = function() { + $elem.parent().on('scroll', drawSelf); $elem.bind('keyup input change', drawSelf); } -- cgit v1.2.3