manual backport of #2426, refs #2411, Improve image attachment management

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

1 files changed, 97 insertions, 0 deletions

diff --git a/tests/unit/Service/ImageServiceTest.php b/tests/unit/Service/ImageServiceTest.php
new file mode 100644
index 000000000..ffbba391d
--- /dev/null
+++ b/tests/unit/Service/ImageServiceTest.php
@@ -0,0 +1,97 @@
+<?php
+
+namespace OCA\Text\Tests;
+
+use OCA\Text\AppInfo\Application;
+use OCA\Text\Service\ImageService;
+use OCP\Files\Folder;
+
+class ImageServiceTest extends \PHPUnit\Framework\TestCase {
+	private static $attachmentNames = [
+		'aaa.png',
+		'aaa (2).png',
+		'aaa 2).png',
+		'aaa (2.png',
+		'aaa ((2.png',
+		'aaa 2)).png',
+		'a[a]a.png',
+		'a(a)a.png',
+		'a](a.png',
+		',;:!?.§-_a_',
+		'a`a`.png',
+	];
+
+	public function testDummy() {
+		$app = new Application();
+		$this->assertEquals('text', $app::APP_NAME);
+	}
+
+	public function testGetOldAttachmentNamesFromContent() {
+		$content = "some content\n";
+		foreach (self::$attachmentNames as $name) {
+			// this is how it's generated in MenuBar.vue
+			$linkText = preg_replace('/[[\]]/', '', $name);
+			$encodedName = urlencode($name);
+			$content .= '![' . $linkText . '](text://image?imageFileName=' . $encodedName . ")\n";
+		}
+		$content .= 'some content';
+
+		$computedNames = ImageService::getAttachmentNamesFromContent($content, 33);
+		foreach (self::$attachmentNames as $contentName) {
+			$this->assertContains($contentName, $computedNames);
+		}
+	}
+
+
+	public function testGetAttachmentNamesFromContent() {
+		$content = "some content\n";
+		foreach (self::$attachmentNames as $name) {
+			// this is how it's generated in MenuBar.vue
+			$linkText = preg_replace('/[[\]]/', '', $name);
+			$encodedName = urlencode($name);
+			$content .= '![' . $linkText . '](.attachments.33/' . $encodedName . ")\n";
+		}
+		$content .= 'some content';
+
+		$computedNames = ImageService::getAttachmentNamesFromContent($content, 33);
+		foreach (self::$attachmentNames as $contentName) {
+			$this->assertContains($contentName, $computedNames);
+		}
+	}
+
+	public function testGetUniqueFileName() {
+		$fileNameList = [
+			'foo.png',
+			'bar',
+			'plop.png',
+			'plop (2).png',
+			'lala.png',
+			'lala (2).png',
+			'lala (3).png',
+			'yay.png',
+			'yay (2).png',
+			'yay (3).png',
+			'yay (5).png',
+			'file.ext.ext',
+		];
+
+		$folder = $this->createMock(Folder::class);
+		$folder->expects(self::any())
+			->method('nodeExists')
+			->willReturnCallback(function ($name) use ($fileNameList) {
+				return in_array($name, $fileNameList);
+			});
+
+		// files that do not exist yet
+		$this->assertEquals('doesNotExistYet', ImageService::getUniqueFileName($folder, 'doesNotExistYet'));
+		$this->assertEquals('doesNotExistYet.png', ImageService::getUniqueFileName($folder, 'doesNotExistYet.png'));
+
+		// files that already exist
+		$this->assertEquals('foo (2).png', ImageService::getUniqueFileName($folder, 'foo.png'));
+		$this->assertEquals('bar (2)', ImageService::getUniqueFileName($folder, 'bar'));
+		$this->assertEquals('plop (3).png', ImageService::getUniqueFileName($folder, 'plop.png'));
+		$this->assertEquals('lala (4).png', ImageService::getUniqueFileName($folder, 'lala.png'));
+		$this->assertEquals('yay (4).png', ImageService::getUniqueFileName($folder, 'yay.png'));
+		$this->assertEquals('file.ext (2).ext', ImageService::getUniqueFileName($folder, 'file.ext.ext'));
+	}
+}