From b4b4f1d38b0440e55a690d1caacceeab2b95a94f Mon Sep 17 00:00:00 2001
From: Julien Veyssier <eneiluj@posteo.net>
Date: Tue, 28 Dec 2021 11:27:36 +0100
Subject: fix stuff after PR comments

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
---
 lib/Service/ImageService.php | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

(limited to 'lib')

diff --git a/lib/Service/ImageService.php b/lib/Service/ImageService.php
index bba8ca5e6..db691a95f 100644
--- a/lib/Service/ImageService.php
+++ b/lib/Service/ImageService.php
@@ -32,6 +32,7 @@ use OCP\Constants;
 use OCP\Files\Folder;
 use OCP\Files\File;
 use OCP\Files\NotFoundException;
+use OCP\Files\NotPermittedException;
 use OCP\Files\SimpleFS\ISimpleFile;
 use OCP\IPreview;
 use OCP\Share\Exceptions\ShareNotFound;
@@ -153,7 +154,7 @@ class ImageService {
 	public function uploadImage(int $documentId, string $newFileName, string $newFileContent, string $userId): array {
 		$textFile = $this->getTextFile($documentId, $userId);
 		if (!$textFile->isUpdateable()) {
-			throw new Exception('No write permissions');
+			throw new NotPermittedException('No write permissions');
 		}
 		$saveDir = $this->getOrCreateAttachmentDirectoryForFile($textFile);
 		if ($saveDir !== null) {
@@ -184,7 +185,7 @@ class ImageService {
 	 */
 	public function uploadImagePublic(?int $documentId, string $newFileName, string $newFileContent, string $shareToken): array {
 		if (!$this->hasUpdatePermissions($shareToken)) {
-			throw new Exception('No write permissions');
+			throw new NotPermittedException('No write permissions');
 		}
 		$textFile = $this->getTextFilePublic($documentId, $shareToken);
 		$saveDir = $this->getOrCreateAttachmentDirectoryForFile($textFile);
@@ -218,7 +219,7 @@ class ImageService {
 	public function insertImageFile(int $documentId, string $path, string $userId): array {
 		$textFile = $this->getTextFile($documentId, $userId);
 		if (!$textFile->isUpdateable()) {
-			throw new Exception('No write permissions');
+			throw new NotPermittedException('No write permissions');
 		}
 		$imageFile = $this->getFileFromPath($path, $userId);
 		$saveDir = $this->getOrCreateAttachmentDirectoryForFile($textFile);
@@ -271,7 +272,7 @@ class ImageService {
 	public function insertImageLink(int $documentId, string $link, string $userId): array {
 		$textFile = $this->getTextFile($documentId, $userId);
 		if (!$textFile->isUpdateable()) {
-			throw new Exception('No write permissions');
+			throw new NotPermittedException('No write permissions');
 		}
 		$saveDir = $this->getOrCreateAttachmentDirectoryForFile($textFile);
 		if ($saveDir !== null) {
@@ -294,7 +295,7 @@ class ImageService {
 	 */
 	public function insertImageLinkPublic(?int $documentId, string $link, string $shareToken): array {
 		if (!$this->hasUpdatePermissions($shareToken)) {
-			throw new Exception('No write permissions');
+			throw new NotPermittedException('No write permissions');
 		}
 		$textFile = $this->getTextFilePublic($documentId, $shareToken);
 		$saveDir = $this->getOrCreateAttachmentDirectoryForFile($textFile);
-- 
cgit v1.2.3