diff options
| author | Gibson Fahnestock <gib@uk.ibm.com> | 2017-01-09 02:23:34 +0300 |
|---|---|---|
| committer | Italo A. Casas <me@italoacasas.com> | 2017-01-30 20:08:41 +0300 |
| commit | c217b438f2793cbc9c85ae4bf9ba981fcb8f1f5a (patch) | |
| tree | de343702f63bae3835329c582191cb2e05750663 /.eslintrc.yaml | |
| parent | 51f4c8bf5cd80d41071589ecafacbad7053f02d1 (diff) | |
assert, tools: enforce strict (not)equal in eslint
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.
Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.
PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Diffstat (limited to '.eslintrc.yaml')
| -rw-r--r-- | .eslintrc.yaml | 28 |
1 files changed, 16 insertions, 12 deletions
diff --git a/.eslintrc.yaml b/.eslintrc.yaml index cf1f36c86bc..4f691caefd3 100644 --- a/.eslintrc.yaml +++ b/.eslintrc.yaml @@ -62,17 +62,21 @@ rules: no-new-require: 2 no-path-concat: 2 no-restricted-modules: [2, sys, _linklist] - no-restricted-properties: [2, { - object: assert, - property: deepEqual, - message: Please use assert.deepStrictEqual(). - }, { - property: __defineGetter__, - message: __defineGetter__ is deprecated. - }, { - property: __defineSetter__, - message: __defineSetter__ is deprecated. - }] + no-restricted-properties: + - 2 + - object: assert + property: deepEqual + message: Use assert.deepStrictEqual(). + - object: assert + property: equal + message: Use assert.strictEqual() rather than assert.equal(). + - object: assert + property: notEqual + message: Use assert.notStrictEqual() rather than assert.notEqual(). + - property: __defineGetter__ + message: __defineGetter__ is deprecated. + - property: __defineSetter__, + message: __defineSetter__ is deprecated. # Stylistic Issues # http://eslint.org/docs/rules/#stylistic-issues @@ -86,7 +90,7 @@ rules: func-name-matching: 2 indent: [2, 2, {ArrayExpression: first, CallExpression: {arguments: first}, - MemberExpression: 1, + MemberExpression: 1, ObjectExpression: first, SwitchCase: 1}] key-spacing: [2, {mode: minimum}] |