diff options
| author | Phillip Johnsen <johphi@gmail.com> | 2020-09-11 22:09:21 +0300 |
|---|---|---|
| committer | Node.js GitHub Bot <github-bot@iojs.org> | 2020-09-14 00:56:03 +0300 |
| commit | 692910dd304644f63d2576d2476c4dca3e33799f (patch) | |
| tree | 0d9b19f57edf1f8ada97a1da8c63aaaa257a62c6 /.github | |
| parent | 35d82af78c1bbd05baa783b3b25f2eb7b48d1848 (diff) | |
build: filter issues & PRs to auto close by matching on stalled label
The auto closing of issues & PRs labelled with `stalled` doesn't seem
to be working as expected. The GitHub Action UI gives the impression
the stale action tries to execute more operations than it is allowed to
do.
Previously there was no filtering on issues & PRs. So when it tries to
fetch all the currently open issues, checking whether or not they should
be get closed, it would have to perform quite a few requests pagination
requests to get the information needed.
Knowing that we only care about issues & PRs already labelled `stalled`,
we can provide the [`only-labels`](https://github.com/actions/stale/blob/13b324e4b28a2708236aadb11361fa65af60d201/action.yml#L38)
option to make sure we only fetch relevant issues.
Refs https://github.com/nodejs/node/issues/35144
PR-URL: https://github.com/nodejs/node/pull/35159
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/close-stalled.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/.github/workflows/close-stalled.yml b/.github/workflows/close-stalled.yml index 89861c64452..335a1eea471 100644 --- a/.github/workflows/close-stalled.yml +++ b/.github/workflows/close-stalled.yml @@ -15,6 +15,8 @@ jobs: stale-issue-label: stalled close-issue-message: Closing this because it has stalled. Feel free to reopen if this issue is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. + # used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues + only-labels: stalled # deactivates automatic removal of stalled label if issue gets any activity remove-stale-when-updated: false # deactivates automatic stale labelling as we prefer to do that manually |