diff options
| author | Darshan Sen <raisinten@gmail.com> | 2022-04-20 02:26:50 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2022-04-28 07:56:13 +0300 |
| commit | 7c973474bf24cf58db4f9242e3683514e33a7c71 (patch) | |
| tree | 8e5603f51a318785026c0cb6dfcfd429901a4c18 /.github | |
| parent | 025b3e786a3773eb078beb46a37376a08ecaaf9f (diff) | |
build: improve the format-cpp error message
This change specifies the target branch name instead of leaving that to
the committer to fill in.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/linters.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index 312ba0b3c97..fa761f4f9de 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -78,7 +78,7 @@ jobs: echo echo 'ERROR: Please run:' echo - echo ' CLANG_FORMAT_START="$(git merge-base HEAD <target-branch-name>)" make format-cpp' + echo " CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp" echo echo 'to format the commits in your branch.' exit "$EXIT_CODE" |