diff options
| author | Rich Trott <rtrott@gmail.com> | 2022-04-04 02:47:02 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-04 02:47:02 +0300 |
| commit | df20947e69dcfe73f0df1ff33ac350748173742e (patch) | |
| tree | db68cad35b6cb0347f7483f686dd4268bf8eb7c7 /.github | |
| parent | d83e7a0b77f8b4494ada010cc287d8ec6ec13828 (diff) | |
build: consolidate JS and md linting GitHub Actions
Linting markdown runs the JavaScript linting job, so consolidate them to
conserve time and resources. Run JavaScript separately, but then run
markdown linting so it can use the cached results of the JavaScript
linting.
PR-URL: https://github.com/nodejs/node/pull/42572
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/linters.yml | 22 |
1 files changed, 4 insertions, 18 deletions
diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index 6eed7015e58..e5eff5ee447 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -49,7 +49,7 @@ jobs: run: npx envinfo - name: Lint C/C++ files run: make lint-cpp - lint-md: + lint-js-and-md: if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -62,32 +62,18 @@ jobs: node-version: ${{ env.NODE_VERSION }} - name: Environment Information run: npx envinfo + - name: Lint JavaScript files + run: NODE=$(command -v node) make lint-js - name: Get release version numbers if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }} id: get-released-versions run: ./tools/lint-md/list-released-versions-from-changelogs.mjs - - name: Lint docs + - name: Lint markdown files run: | echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json" NODE=$(command -v node) make lint-md env: NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }} - - lint-js: - if: github.event.pull_request.draft == false - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - with: - persist-credentials: false - - name: Use Node.js ${{ env.NODE_VERSION }} - uses: actions/setup-node@v3 - with: - node-version: ${{ env.NODE_VERSION }} - - name: Environment Information - run: npx envinfo - - name: Lint JavaScript files - run: NODE=$(command -v node) make lint-js lint-py: if: github.event.pull_request.draft == false runs-on: ubuntu-latest |