Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNatanael Copa <ncopa@alpinelinux.org>2016-02-05 13:46:47 +0300
committerEvan Lucas <evanlucas@me.com>2016-06-23 16:00:26 +0300
commit2ebeb82852d49975c5a21fc3fd6f9ba98ba9fbfa (patch)
treec3d96eb475680ad81daba8a02ec674fc275d20f8
parent34b96c1322b60d5e8ac7ee91df1a6984cbc9c4e6 (diff)
test: fix test-net-* error code check for getaddrinfo(3)
Replace '...' as invalid hostname with '***', which will give a more consisten error message on different systems. The hostname '...' returns EAI_AGAIN on musl libc and EAI_NONAME on most other systems. By changing the testcase we get same restult on all known platforms. PR-URL: https://github.com/nodejs/node/pull/5099 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
-rw-r--r--test/parallel/test-net-better-error-messages-port-hostname.js4
-rw-r--r--test/parallel/test-net-connect-immediate-finish.js4
2 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-net-better-error-messages-port-hostname.js b/test/parallel/test-net-better-error-messages-port-hostname.js
index 9db6fb26f57..23089baf448 100644
--- a/test/parallel/test-net-better-error-messages-port-hostname.js
+++ b/test/parallel/test-net-better-error-messages-port-hostname.js
@@ -3,12 +3,12 @@ var common = require('../common');
var net = require('net');
var assert = require('assert');
-var c = net.createConnection(common.PORT, '...');
+var c = net.createConnection(common.PORT, '***');
c.on('connect', common.fail);
c.on('error', common.mustCall(function(e) {
assert.equal(e.code, 'ENOTFOUND');
assert.equal(e.port, common.PORT);
- assert.equal(e.hostname, '...');
+ assert.equal(e.hostname, '***');
}));
diff --git a/test/parallel/test-net-connect-immediate-finish.js b/test/parallel/test-net-connect-immediate-finish.js
index a5403732ec1..6114233677f 100644
--- a/test/parallel/test-net-connect-immediate-finish.js
+++ b/test/parallel/test-net-connect-immediate-finish.js
@@ -3,14 +3,14 @@ const common = require('../common');
const assert = require('assert');
const net = require('net');
-const client = net.connect({host: '...', port: common.PORT});
+const client = net.connect({host: '***', port: common.PORT});
client.once('error', common.mustCall(function(err) {
assert(err);
assert.strictEqual(err.code, err.errno);
assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(err.host, err.hostname);
- assert.strictEqual(err.host, '...');
+ assert.strictEqual(err.host, '***');
assert.strictEqual(err.syscall, 'getaddrinfo');
}));