diff options
author | Rod Vagg <rod@vagg.org> | 2016-10-18 13:26:39 +0300 |
---|---|---|
committer | Rod Vagg <rod@vagg.org> | 2016-10-18 16:41:01 +0300 |
commit | 5f1097dcb0188ec313811d11ba84de5a26cb45b8 (patch) | |
tree | cae6bdcff5f1d54520d3adb907949f9e5cb1fc39 | |
parent | c5b095ecf832f411f60e503262505255db0230ce (diff) |
win,build: try multiple timeservers when signing
PR-URL: https://github.com/nodejs/node/pull/9155
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: João Reis <reis@janeasystems.com>
-rw-r--r-- | tools/sign.bat | 15 | ||||
-rw-r--r-- | vcbuild.bat | 4 |
2 files changed, 17 insertions, 2 deletions
diff --git a/tools/sign.bat b/tools/sign.bat new file mode 100644 index 00000000000..aa003bca681 --- /dev/null +++ b/tools/sign.bat @@ -0,0 +1,15 @@ +@echo off
+
+set timeservers=(http://timestamp.globalsign.com/scripts/timestamp.dll http://timestamp.comodoca.com/authenticode http://timestamp.verisign.com/scripts/timestamp.dll http://tsa.starfieldtech.com)
+
+for %%s in %timeservers% do (
+ signtool sign /a /d "node" /t %%s %1
+ if not ERRORLEVEL 1 (
+ echo Successfully signed %1 using timeserver %%s
+ exit /b 0
+ )
+ echo Signing %1 failed using %%s
+)
+
+echo Could not sign %1 using any available timeserver
+exit /b 1
diff --git a/vcbuild.bat b/vcbuild.bat index 07be31d884e..6c2bf386b70 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -231,7 +231,7 @@ if errorlevel 1 goto exit @rem Skip signing if the `nosign` option was specified. if defined nosign goto licensertf -signtool sign /a /d "node" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\node.exe +call tools\sign.bat Release\node.exe if errorlevel 1 echo Failed to sign exe&goto exit :licensertf @@ -251,7 +251,7 @@ msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build /p:PlatformToolset=% if errorlevel 1 goto exit if defined nosign goto upload -signtool sign /a /d "node" /t http://timestamp.globalsign.com/scripts/timestamp.dll node-v%FULLVERSION%-%target_arch%.msi +call tools\sign.bat node-v%FULLVERSION%-%target_arch%.msi if errorlevel 1 echo Failed to sign msi&goto exit :upload |