diff options
| author | Julien Gilli <julien.gilli@joyent.com> | 2017-02-03 22:57:25 +0300 |
|---|---|---|
| committer | Myles Borins <myles.borins@gmail.com> | 2017-02-22 00:38:21 +0300 |
| commit | c279cbe6a954b22eee59113ccec173ee1c283989 (patch) | |
| tree | e5df58c59f74da54bfa42910ea40d3b0b39e34b6 | |
| parent | 0f5d82e583fb4e6eb7597da50b4b9b15ec58d101 (diff) | |
test: fix test.py command line options processing
https://github.com/nodejs/node/pull/11086 had introduced a regression
that broke command line options processing for tools/test.py.
Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:
```
$ python tools/test.py --abort-on-timeout path/to/some-test
```
all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.
This change fixes this regression.
Refs: https://github.com/nodejs/node/pull/11086
PR-URL: https://github.com/nodejs/node/pull/11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
| -rwxr-xr-x | tools/test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/test.py b/tools/test.py index b511004a737..42f25ae5220 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1414,7 +1414,7 @@ def BuildOptions(): default=1, type="int") result.add_option('--abort-on-timeout', help='Send SIGABRT instead of SIGTERM to kill processes that time out', - default=False, dest="abort_on_timeout") + default=False, action="store_true", dest="abort_on_timeout") return result |