diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-05-17 23:11:02 +0300 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2019-05-23 18:51:39 +0300 |
commit | 2ecef9b5f21d4f30a84d7ca80acf40ea041a8980 (patch) | |
tree | 14f90a318d29402091e80c8efed30e3c9916c7ac | |
parent | 6ded4f2bad519d2c201c855b9ba87095bc29d71b (diff) |
src: remove memory_tracker-inl.h from header files
Inline headers should only be included into the .cc files that use them.
PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | src/base_object.h | 2 | ||||
-rw-r--r-- | src/cares_wrap.cc | 1 | ||||
-rw-r--r-- | src/env.cc | 1 | ||||
-rw-r--r-- | src/heap_utils.cc | 1 | ||||
-rw-r--r-- | src/inspector_js_api.cc | 1 | ||||
-rw-r--r-- | src/inspector_profiler.cc | 1 | ||||
-rw-r--r-- | src/module_wrap.cc | 1 | ||||
-rw-r--r-- | src/node.cc | 1 | ||||
-rw-r--r-- | src/node_config.cc | 1 | ||||
-rw-r--r-- | src/node_contextify.cc | 1 | ||||
-rw-r--r-- | src/node_crypto.cc | 1 | ||||
-rw-r--r-- | src/node_crypto_bio.cc | 1 | ||||
-rw-r--r-- | src/node_file.cc | 1 | ||||
-rw-r--r-- | src/node_http2.cc | 1 | ||||
-rw-r--r-- | src/node_http_parser_llhttp.cc | 1 | ||||
-rw-r--r-- | src/node_http_parser_traditional.cc | 1 | ||||
-rw-r--r-- | src/node_messaging.cc | 1 | ||||
-rw-r--r-- | src/node_perf.cc | 1 | ||||
-rw-r--r-- | src/node_stat_watcher.cc | 1 | ||||
-rw-r--r-- | src/node_trace_events.cc | 1 | ||||
-rw-r--r-- | src/node_worker.cc | 1 | ||||
-rw-r--r-- | src/node_zlib.cc | 1 | ||||
-rw-r--r-- | src/tls_wrap.cc | 1 |
23 files changed, 23 insertions, 1 deletions
diff --git a/src/base_object.h b/src/base_object.h index cb83462ff51..f616108a1d9 100644 --- a/src/base_object.h +++ b/src/base_object.h @@ -24,7 +24,7 @@ #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS -#include "memory_tracker-inl.h" +#include "memory_tracker.h" #include "v8.h" #include <type_traits> // std::remove_reference diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index 07882a4212c..0be02596f96 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -23,6 +23,7 @@ #include "ares.h" #include "async_wrap-inl.h" #include "env-inl.h" +#include "memory_tracker-inl.h" #include "node.h" #include "req_wrap-inl.h" #include "util-inl.h" diff --git a/src/env.cc b/src/env.cc index 5f408f18f14..bc43fac963b 100644 --- a/src/env.cc +++ b/src/env.cc @@ -1,6 +1,7 @@ #include "env.h" #include "async_wrap.h" +#include "memory_tracker-inl.h" #include "node_buffer.h" #include "node_context_data.h" #include "node_errors.h" diff --git a/src/heap_utils.cc b/src/heap_utils.cc index ee0665cfe27..acc63fd1d9a 100644 --- a/src/heap_utils.cc +++ b/src/heap_utils.cc @@ -1,4 +1,5 @@ #include "env-inl.h" +#include "memory_tracker-inl.h" #include "stream_base-inl.h" #include "util-inl.h" diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc index 5caf3fa09a4..9d649385706 100644 --- a/src/inspector_js_api.cc +++ b/src/inspector_js_api.cc @@ -1,6 +1,7 @@ #include "base_object-inl.h" #include "inspector_agent.h" #include "inspector_io.h" +#include "memory_tracker-inl.h" #include "util-inl.h" #include "v8.h" #include "v8-inspector.h" diff --git a/src/inspector_profiler.cc b/src/inspector_profiler.cc index 4604e0a5b44..7e76ad778a0 100644 --- a/src/inspector_profiler.cc +++ b/src/inspector_profiler.cc @@ -2,6 +2,7 @@ #include <sstream> #include "base_object-inl.h" #include "debug_utils.h" +#include "memory_tracker-inl.h" #include "node_file.h" #include "node_internals.h" #include "v8-inspector.h" diff --git a/src/module_wrap.cc b/src/module_wrap.cc index a4e81dcc294..e104afb736c 100644 --- a/src/module_wrap.cc +++ b/src/module_wrap.cc @@ -1,6 +1,7 @@ #include "module_wrap.h" #include "env.h" +#include "memory_tracker-inl.h" #include "node_errors.h" #include "node_url.h" #include "util-inl.h" diff --git a/src/node.cc b/src/node.cc index e559d65345c..0edc6fd4ce0 100644 --- a/src/node.cc +++ b/src/node.cc @@ -25,6 +25,7 @@ #include "debug_utils.h" #include "env-inl.h" +#include "memory_tracker-inl.h" #include "node_binding.h" #include "node_internals.h" #include "node_main_instance.h" diff --git a/src/node_config.cc b/src/node_config.cc index 335ebedc583..92985dff2f8 100644 --- a/src/node_config.cc +++ b/src/node_config.cc @@ -1,4 +1,5 @@ #include "env-inl.h" +#include "memory_tracker.h" #include "node.h" #include "node_i18n.h" #include "node_native_module_env.h" diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 77622f8cbd6..ee5a9db574f 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -21,6 +21,7 @@ #include "node_contextify.h" +#include "memory_tracker-inl.h" #include "node_internals.h" #include "node_watchdog.h" #include "base_object-inl.h" diff --git a/src/node_crypto.cc b/src/node_crypto.cc index f38ed3907dd..76a8cc8a193 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -32,6 +32,7 @@ #include "async_wrap-inl.h" #include "base_object-inl.h" #include "env-inl.h" +#include "memory_tracker-inl.h" #include "string_bytes.h" #include "threadpoolwork-inl.h" #include "util-inl.h" diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc index fcbe30ca9c0..9f06801c3ae 100644 --- a/src/node_crypto_bio.cc +++ b/src/node_crypto_bio.cc @@ -20,6 +20,7 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. #include "base_object-inl.h" +#include "memory_tracker-inl.h" #include "node_crypto_bio.h" #include "openssl/bio.h" #include "util-inl.h" diff --git a/src/node_file.cc b/src/node_file.cc index 4da2a4f53cb..8f82d639d6d 100644 --- a/src/node_file.cc +++ b/src/node_file.cc @@ -21,6 +21,7 @@ #include "node_file.h" #include "aliased_buffer.h" +#include "memory_tracker-inl.h" #include "node_buffer.h" #include "node_process.h" #include "node_stat_watcher.h" diff --git a/src/node_http2.cc b/src/node_http2.cc index 0c650290c2b..d9b886284dd 100644 --- a/src/node_http2.cc +++ b/src/node_http2.cc @@ -1,5 +1,6 @@ #include "aliased_buffer.h" #include "debug_utils.h" +#include "memory_tracker-inl.h" #include "node.h" #include "node_buffer.h" #include "node_http2.h" diff --git a/src/node_http_parser_llhttp.cc b/src/node_http_parser_llhttp.cc index d2063873f17..6e1d18d3af9 100644 --- a/src/node_http_parser_llhttp.cc +++ b/src/node_http_parser_llhttp.cc @@ -1,6 +1,7 @@ #define NODE_EXPERIMENTAL_HTTP 1 #include "node_http_parser_impl.h" +#include "memory_tracker-inl.h" #include "node_metadata.h" #include "util-inl.h" diff --git a/src/node_http_parser_traditional.cc b/src/node_http_parser_traditional.cc index 7b413af8b6c..11aa387f109 100644 --- a/src/node_http_parser_traditional.cc +++ b/src/node_http_parser_traditional.cc @@ -2,6 +2,7 @@ #undef NODE_EXPERIMENTAL_HTTP #endif +#include "memory_tracker-inl.h" #include "node_http_parser_impl.h" #include "node_metadata.h" #include "util-inl.h" diff --git a/src/node_messaging.cc b/src/node_messaging.cc index ea7b48779ca..fa583a25703 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -2,6 +2,7 @@ #include "async_wrap-inl.h" #include "debug_utils.h" +#include "memory_tracker-inl.h" #include "node_contextify.h" #include "node_buffer.h" #include "node_errors.h" diff --git a/src/node_perf.cc b/src/node_perf.cc index 08632020300..f43c1021362 100644 --- a/src/node_perf.cc +++ b/src/node_perf.cc @@ -1,4 +1,5 @@ #include "aliased_buffer.h" +#include "memory_tracker-inl.h" #include "node_internals.h" #include "node_perf.h" #include "node_buffer.h" diff --git a/src/node_stat_watcher.cc b/src/node_stat_watcher.cc index b7fb45900f9..ae30825cbbd 100644 --- a/src/node_stat_watcher.cc +++ b/src/node_stat_watcher.cc @@ -19,6 +19,7 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. +#include "memory_tracker-inl.h" #include "node_stat_watcher.h" #include "async_wrap-inl.h" #include "env.h" diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc index 13072a3340c..24e1d66fb7e 100644 --- a/src/node_trace_events.cc +++ b/src/node_trace_events.cc @@ -1,5 +1,6 @@ #include "base_object-inl.h" #include "env.h" +#include "memory_tracker-inl.h" #include "node.h" #include "node_internals.h" #include "node_v8_platform-inl.h" diff --git a/src/node_worker.cc b/src/node_worker.cc index 20b883664da..e84b36f132a 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -1,5 +1,6 @@ #include "node_worker.h" #include "debug_utils.h" +#include "memory_tracker-inl.h" #include "node_errors.h" #include "node_buffer.h" #include "node_options-inl.h" diff --git a/src/node_zlib.cc b/src/node_zlib.cc index d816c7caff9..30fef0ff1d4 100644 --- a/src/node_zlib.cc +++ b/src/node_zlib.cc @@ -19,6 +19,7 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. +#include "memory_tracker-inl.h" #include "node.h" #include "node_buffer.h" diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc index a1944df0563..69293ad906e 100644 --- a/src/tls_wrap.cc +++ b/src/tls_wrap.cc @@ -22,6 +22,7 @@ #include "tls_wrap.h" #include "async_wrap-inl.h" #include "debug_utils.h" +#include "memory_tracker-inl.h" #include "node_buffer.h" // Buffer #include "node_crypto.h" // SecureContext #include "node_crypto_bio.h" // NodeBIO |