Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuigi Pinca <luigipinca@gmail.com>2022-07-12 23:11:10 +0300
committerLuigi Pinca <luigipinca@gmail.com>2022-11-05 21:53:03 +0300
commit60de1476eadfb83e23177a9d5135897661e957f7 (patch)
tree633417b34df0909f139c1a0cce7ab49cd05fd7c4
parent58431c0e6bb1829b6ccafc5cf6340226c15da790 (diff)
test: fix test-socket-write-after-fin-error
The `'error'` event is not emitted because the socket is already destroyed when `socket.write()` is called. Use the `socket.write()` callback instead. PR-URL: https://github.com/nodejs/node/pull/42340 Refs: https://github.com/nodejs/node/pull/42340#issuecomment-1182387070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
-rw-r--r--test/parallel/test-socket-write-after-fin-error.js10
1 files changed, 5 insertions, 5 deletions
diff --git a/test/parallel/test-socket-write-after-fin-error.js b/test/parallel/test-socket-write-after-fin-error.js
index 64c8143abeb..0e3b99abac7 100644
--- a/test/parallel/test-socket-write-after-fin-error.js
+++ b/test/parallel/test-socket-write-after-fin-error.js
@@ -16,10 +16,7 @@ let gotServerError = false;
const server = net.createServer(function(sock) {
sock.setEncoding('utf8');
- sock.on('error', function(er) {
- console.error(`${er.code}: ${er.message}`);
- gotServerError = er;
- });
+ sock.on('error', function() {});
sock.on('data', function(c) {
serverData += c;
@@ -27,7 +24,10 @@ const server = net.createServer(function(sock) {
sock.on('end', function() {
gotServerEnd = true;
setImmediate(() => {
- sock.write(serverData);
+ sock.write(serverData, function(er) {
+ console.error(`${er.code}: ${er.message}`);
+ gotServerError = er;
+ });
sock.end();
});
});