diff options
author | Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> | 2020-09-16 00:04:48 +0300 |
---|---|---|
committer | Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> | 2020-09-18 01:53:16 +0300 |
commit | c9506a8f3e9bc5c679151feb39198023154464ab (patch) | |
tree | 90d2ea6d6d2603e0af0ac97fda35a910ad5c7244 | |
parent | 59ca56eddefc78bab87d7e8e074b3af843ab1bc3 (diff) |
n-api: add more property defaults
Add a default value for class method and js like property in enum
napi_property_attributes.
n-api currently offers only one default which is non configurable,
non writable, non enumerable - like Object.defineProperty(). While
this is formal correct the usual way to create properties in JS is
either by defining a class or use obj.prop = value.
The defaults from these variants are now backed into enum values.
PR-URL: https://github.com/nodejs/node/pull/35214
Refs: https://github.com/nodejs/node-addon-api/issues/811
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
-rw-r--r-- | doc/api/n-api.md | 18 | ||||
-rw-r--r-- | src/js_native_api_types.h | 10 |
2 files changed, 28 insertions, 0 deletions
diff --git a/doc/api/n-api.md b/doc/api/n-api.md index db43ee18aff..22fe991142f 100644 --- a/doc/api/n-api.md +++ b/doc/api/n-api.md @@ -3731,6 +3731,12 @@ if (status != napi_ok) return status; ### Structures #### napi_property_attributes +<!-- YAML +changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/35214 + description: added `napi_default_method` and `napi_default_property` +--> ```c typedef enum { @@ -3742,6 +3748,14 @@ typedef enum { // Used with napi_define_class to distinguish static properties // from instance properties. Ignored by napi_define_properties. napi_static = 1 << 10, + + // Default for class methods. + napi_default_method = napi_writable | napi_configurable, + + // Default for object properties, like in JS obj[prop]. + napi_default_property = napi_writable | + napi_enumerable | + napi_configurable, } napi_property_attributes; ``` @@ -3760,6 +3774,10 @@ They can be one or more of the following bitflags: * `napi_static`: The property will be defined as a static property on a class as opposed to an instance property, which is the default. This is used only by [`napi_define_class`][]. It is ignored by `napi_define_properties`. +* `napi_default_method`: The property is configureable, writeable but not + enumerable like a method in a JS class. +* `napi_default_property`: The property is writable, enumerable and configurable + like a property set via JS code `obj.key = value`. #### napi_property_descriptor diff --git a/src/js_native_api_types.h b/src/js_native_api_types.h index 115ccebf261..7011c80e671 100644 --- a/src/js_native_api_types.h +++ b/src/js_native_api_types.h @@ -30,6 +30,16 @@ typedef enum { // Used with napi_define_class to distinguish static properties // from instance properties. Ignored by napi_define_properties. napi_static = 1 << 10, + +#ifdef NAPI_EXPERIMENTAL + // Default for class methods. + napi_default_method = napi_writable | napi_configurable, + + // Default for object properties, like in JS obj[prop]. + napi_default_jsproperty = napi_writable | + napi_enumerable | + napi_configurable, +#endif // NAPI_EXPERIMENTAL } napi_property_attributes; typedef enum { |