diff options
| author | Michaël Zasso <targos@protonmail.com> | 2021-03-06 12:07:54 +0300 |
|---|---|---|
| committer | Ruy Adorno <ruyadorno@hotmail.com> | 2021-03-30 03:17:20 +0300 |
| commit | e60bd1a7dc5e51c08f9fc188558e5532602ac2bd (patch) | |
| tree | 5361a5fa535fb93e384ab6b47a00051ece92aa5d | |
| parent | d33f446abded4a71f6ae180b30c954e455b5aed8 (diff) | |
perf_hooks: make Performance extend EventTarget
Refs: https://www.w3.org/TR/hr-time/#sec-performance
PR-URL: https://github.com/nodejs/node/pull/37621
Backport-PR-URL: https://github.com/nodejs/node/pull/37832
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | lib/perf_hooks.js | 6 | ||||
| -rw-r--r-- | test/wpt/status/hr-time.json | 3 |
2 files changed, 5 insertions, 4 deletions
diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js index 6a759bbbf4e..474cdadc772 100644 --- a/lib/perf_hooks.js +++ b/lib/perf_hooks.js @@ -54,6 +54,9 @@ const { NODE_PERFORMANCE_MILESTONE_ENVIRONMENT } = constants; +const { + EventTarget, +} = require('internal/event_target'); const L = require('internal/linkedlist'); const kInspect = require('internal/util').customInspectSymbol; @@ -418,8 +421,9 @@ class PerformanceObserver { } } -class Performance { +class Performance extends EventTarget { constructor() { + super(); this[kIndex] = { [kMarks]: new SafeSet() }; diff --git a/test/wpt/status/hr-time.json b/test/wpt/status/hr-time.json index 4910d925b5b..cb9f26a2ebc 100644 --- a/test/wpt/status/hr-time.json +++ b/test/wpt/status/hr-time.json @@ -1,7 +1,4 @@ { - "basic.any.js": { - "fail": "self.performance.addEventListener is not a function" - }, "idlharness.any.js": { "skip": "TODO: update IDL parser" }, |