diff options
| author | Lucas Holmquist <lholmqui@redhat.com> | 2019-09-30 20:56:26 +0300 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-10-09 22:35:41 +0300 |
| commit | 014eb67117fb360d97e8b0bc3fa2c57803c02184 (patch) | |
| tree | 70606537896a0bf3fa02828a340b58f6eacdf691 | |
| parent | 62370efe7ed5b15db56619b64afff597e79ab3fe (diff) | |
doc: add documentation deprecation for process._tickCallback
This change also supports --pending-deprecation for the new deprecation.
PR-URL: https://github.com/nodejs/node/pull/29781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
| -rw-r--r-- | doc/api/deprecations.md | 27 | ||||
| -rw-r--r-- | lib/internal/bootstrap/pre_execution.js | 4 |
2 files changed, 31 insertions, 0 deletions
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 35bda82f591..e45130340c7 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2494,6 +2494,33 @@ Type: Runtime Passing a callback to [`worker.terminate()`][] is deprecated. Use the returned `Promise` instead, or a listener to the worker’s `'exit'` event. +<a id="DEP0133"></a> +### DEP0133: http connection +<!-- YAML +changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/29015 + description: Documentation-only deprecation. +--> + +Type: Documentation-only + +Prefer [`response.socket`][] over [`response.connection`] and +[`request.socket`][] over [`request.connection`]. + +<a id="DEP0XXX"></a> +### DEP0XXX: process._tickCallback +<!-- YAML +changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/29781 + description: Documentation-only deprecation. +--> +Type: Documentation-only (supports [`--pending-deprecation`][]) + +The `process._tickCallback` property was never documented as +an officially supported API. + [`--http-parser=legacy`]: cli.html#cli_http_parser_library [`--pending-deprecation`]: cli.html#cli_pending_deprecation [`--throw-deprecation`]: cli.html#cli_throw_deprecation diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js index 79f1d97fbb3..626791a5725 100644 --- a/lib/internal/bootstrap/pre_execution.js +++ b/lib/internal/bootstrap/pre_execution.js @@ -271,6 +271,10 @@ function initializeDeprecations() { process.binding = deprecate(process.binding, 'process.binding() is deprecated. ' + 'Please use public APIs instead.', 'DEP0111'); + + process._tickCallback = deprecate(process._tickCallback, + 'process._tickCallback() is deprecated', + 'DEP0XXX'); } // Create global.process and global.Buffer as getters so that we have a |