diff options
| author | Richard Lau <rlau@redhat.com> | 2021-05-06 01:48:14 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-06-11 10:30:15 +0300 |
| commit | 754aa384e0c686a4fac00900ef22b733b0533df0 (patch) | |
| tree | 368009bbbb3eaf19d10e5a50660d072b97684910 /BUILDING.md | |
| parent | bac9ba4f8a1ad4da956e4be47b57e8fd43ebce0f (diff) | |
build: remove dependency on `distutils.spawn`
Debian based packages of Python 3 do not include `distutils.spawn` and
require an additional apt package to be installed (`python3-distutils`).
Replace use of `distutils.spawn` with `shutil.which`, available in all
versions of Python currently allowed by our configure scripts.
For the `configure` script only, fall back to `distutils.spawn` to allow
friendlier error messages when run on older unsupported versions of
Python (e.g. 2.7).
`configure.py` also uses `distutils.version` -- this appears to be
available in Debian packaged Python 3 without installing
`python3-distutils` so has been left as-is.
PR-URL: https://github.com/nodejs/node/pull/38600
Refs: https://github.com/nodejs/node/issues/30189
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'BUILDING.md')
| -rw-r--r-- | BUILDING.md | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/BUILDING.md b/BUILDING.md index 2b29b444414..21bb35fa922 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -250,8 +250,6 @@ Installation via Linux package manager can be achieved with: FreeBSD and OpenBSD users may also need to install `libexecinfo`. -Python 3 users may also need to install `python3-distutils`. - #### macOS prerequisites * Xcode Command Line Tools >= 10 for macOS @@ -277,11 +275,6 @@ $ ./configure $ make -j4 ``` -If you run into a `No module named 'distutils.spawn'` error when executing -`./configure`, please try `python3 -m pip install --upgrade setuptools` or -`sudo apt install python3-distutils -y`. -For more information, see <https://github.com/nodejs/node/issues/30189>. - The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which may reduce build time. For more information, see the [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html). |