diff options
| author | suraiyah <hameedsuraiya@gmail.com> | 2017-10-06 19:45:03 +0300 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-10-09 11:32:32 +0300 |
| commit | e8bf4d5dea8e9ade5237b6b8957fae075c4436b5 (patch) | |
| tree | 7c697f4b0617250cc5e790d99c1b02c11f01fe5c /BUILDING.md | |
| parent | 0e1a9fafddd3ba852e2754288799fe4d1be6269f (diff) | |
doc: fix macosx-firewall suggestion BUILDING
Adding back the changes made by commit# 791d560, that suggests running
macosx-firewall.sh script after bulid step. These changes were deleted
by commit# fc102d0, but they are still applicable.
PR-URL: https://github.com/nodejs/node/pull/15829
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'BUILDING.md')
| -rw-r--r-- | BUILDING.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/BUILDING.md b/BUILDING.md index a16b9182e08..e9a6a8faf95 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -88,7 +88,7 @@ On macOS you will need to install the `Xcode Command Line Tools` by running installed, you can find them under the menu `Xcode -> Open Developer Tool -> More Developer Tools...`. This step will install `clang`, `clang++`, and `make`. -* You may want to setup [firewall rules](tools/macosx-firewall.sh) +* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid popups asking to accept incoming network connections when running tests: If the path to your build directory contains a space, the build will likely fail. |