diff options
| author | James M Snell <jasnell@gmail.com> | 2017-10-26 19:08:38 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-10-29 20:07:16 +0300 |
| commit | 1cdcab09f2a9cc010437129376983ac77c9afd7e (patch) | |
| tree | e83ac187694b3d5fdfff682ac8de96be0c5bbfd2 /CONTRIBUTING.md | |
| parent | 980ebd2d35d9e001bcf24aee8a1f061ed2c7c70f (diff) | |
doc: slightly relax 50 character rule
Allow commit message first line to exceed 50 chars if necessary
PR-URL: https://github.com/nodejs/node/pull/16523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1c6de8d2549..99278a843af 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -309,8 +309,8 @@ notes about [commit squashing](#commit-squashing)). A good commit message should describe what changed and why. 1. The first line should: - - contain a short description of the change - - be 50 characters or less + - contain a short description of the change (preferably 50 characters or less, + and no more than 72 characters) - be entirely in lowercase with the exception of proper nouns, acronyms, and the words that refer to code, like function/variable names - be prefixed with the name of the changed subsystem and start with an |