diff options
| author | Rich Trott <rtrott@gmail.com> | 2021-12-30 02:06:21 +0300 |
|---|---|---|
| committer | Danielle Adams <adamzdanielle@gmail.com> | 2022-02-01 07:54:21 +0300 |
| commit | bc48ed283469b3f9d440b90ca5f0a9a3b6ed6d7b (patch) | |
| tree | e1146e6d246abca233c90eb9fe77ef848787ecb4 /benchmark | |
| parent | 7cef7699e3f157be0ea31fb185d45ef9a040fe91 (diff) | |
benchmark: fix benchmark/run.js handling of --set
run.js does not work with --set as it tries to include it as
options to `fork()` rather than as part of argv for `fork()`. This
doesn't throw an error because of a quirk in `fork()` that silently
accepts arrays for options objects. This will be changing in Node.js
18.x.
PR-URL: https://github.com/nodejs/node/pull/41334
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'benchmark')
| -rw-r--r-- | benchmark/run.js | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/benchmark/run.js b/benchmark/run.js index aa7c71bdd4e..a3c9da12f8b 100644 --- a/benchmark/run.js +++ b/benchmark/run.js @@ -42,8 +42,7 @@ if (format === 'csv') { const filename = benchmarks[i]; const child = fork( path.resolve(__dirname, filename), - cli.test ? ['--test'] : [], - cli.optional.set + cli.test ? ['--test'] : cli.optional.set ); if (format !== 'csv') { |