diff options
| author | Michaël Zasso <targos@protonmail.com> | 2022-01-29 10:35:31 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2022-02-02 19:24:51 +0300 |
| commit | 48708be57b5fb9e08df242e273aeb80a82bc48fc (patch) | |
| tree | c0aec6a083263108e7bfe03271598ab1fb92bf2a /common.gypi | |
| parent | ae5edcf2d80ad7b05a4369aaea938695ae560c00 (diff) | |
deps: V8: cherry-pick 79a9d2eb3477
Original commit message:
Fix destructor for EmbedderStateScope
EmbedderState is forward declared in public header for
EmbedderStateScope. Default std::unique_ptr's destructor needs a fully
defined class. Defining default destructor in implementation file fixes
this.
Bug: chromium:1263871
Change-Id: I8ccc58f56a758927dc5d7a39387188185e7d3827
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338697
Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78363}
Refs: https://github.com/v8/v8/commit/79a9d2eb34774163c5b2596418bf50196dc5df4a
PR-URL: https://github.com/nodejs/node/pull/41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 5e75a899ae8..9e52bb1d97e 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### |