diff options
| author | Myles Borins <mylesborins@github.com> | 2020-11-04 06:07:34 +0300 |
|---|---|---|
| committer | Node.js GitHub Bot <github-bot@iojs.org> | 2020-11-07 16:17:55 +0300 |
| commit | 115722b553a6d547815d8df30d819326db6a7eb7 (patch) | |
| tree | a7ff2365537f336f49023917e31bbd4b20021c97 /configure.py | |
| parent | cef144421c5ff6e9677ecf0b7a607000b744aa13 (diff) | |
tools: don't print gold linker warning w/o flag
Currently warning is printed called even if the selection ordering flag
has not been passed.
Only print warning if `--limit-configure-section-file`
has been passed to configure.
Fixes: https://github.com/nodejs/node/issues/35872
PR-URL: https://github.com/nodejs/node/pull/35955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/configure.py b/configure.py index d68d8fc96ab..eb78598d9d3 100755 --- a/configure.py +++ b/configure.py @@ -1761,7 +1761,8 @@ def configure_section_file(o): proc = subprocess.Popen(['ld.gold'] + ['-v'], stdin = subprocess.PIPE, stdout = subprocess.PIPE, stderr = subprocess.PIPE) except OSError: - warn('''No acceptable ld.gold linker found!''') + if options.node_section_ordering_info != "": + warn('''No acceptable ld.gold linker found!''') return 0 match = re.match(r"^GNU gold.*([0-9]+)\.([0-9]+)$", |