diff options
author | Richard Lau <rlau@redhat.com> | 2021-03-26 22:18:07 +0300 |
---|---|---|
committer | Antoine du Hamel <duhamelantoine1995@gmail.com> | 2021-03-28 20:32:18 +0300 |
commit | 558d1e6c221e9392b5d2205e94a2c357067bd79c (patch) | |
tree | 3a3462bd83c388ceae26707b9f3c7e272eb2d34f /configure.py | |
parent | 19ed27d61fd74d8d6568ae4a9944151a5e0c9e6e (diff) |
build: warn for gcc versions earlier than 8.3.0
Update the warning threshold to match the minimum supported version
of gcc. Builds can still proceed, but are not guaranteed to work.
PR-URL: https://github.com/nodejs/node/pull/37935
Refs: https://github.com/nodejs/node/pull/37871
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure.py')
-rwxr-xr-x | configure.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/configure.py b/configure.py index b526507fee9..784e21475df 100755 --- a/configure.py +++ b/configure.py @@ -960,8 +960,8 @@ def check_compiler(o): ('clang ' if is_clang else '', CXX, version_str)) if not ok: warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX) - elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0): - warn('C++ compiler (CXX=%s, %s) too old, need g++ 6.3.0 or clang++ 8.0.0' % + elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0): + warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' % (CXX, version_str)) ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c') |