diff options
| author | Michaël Zasso <targos@protonmail.com> | 2022-04-09 12:09:42 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2022-04-12 23:10:11 +0300 |
| commit | 01cea9a8d8f322b792df42b0eb6ce6d522124cf4 (patch) | |
| tree | d01ee04794e43c891399f078ff42793121b3d85b /deps | |
| parent | d9d26b08efab7c17f5580bbdf78f51c17d60cd5d (diff) | |
deps: V8: cherry-pick a2cae2180a7a
Original commit message:
[runtime] Fix handling of interceptors, pt.2
Stores to undeclared global in strict mode should throw ReferenceError.
Bug: chromium:1309225
Change-Id: Iac7c55da2ff9c16e488b4fc66408c5300469873e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3553099
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79625}
Refs: https://github.com/v8/v8/commit/a2cae2180a7a6d64ccdede44d730c9fbba690fb7
PR-URL: https://github.com/nodejs/node/pull/42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/src/objects/objects.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/deps/v8/src/objects/objects.cc b/deps/v8/src/objects/objects.cc index 3fa06d921c0..e80a6d699cb 100644 --- a/deps/v8/src/objects/objects.cc +++ b/deps/v8/src/objects/objects.cc @@ -2702,6 +2702,10 @@ Maybe<bool> Object::SetSuperProperty(LookupIterator* it, Handle<Object> value, JSReceiver::GetOwnPropertyDescriptor(&own_lookup, &desc); MAYBE_RETURN(owned, Nothing<bool>()); if (!owned.FromJust()) { + if (!CheckContextualStoreToJSGlobalObject(&own_lookup, + should_throw)) { + return Nothing<bool>(); + } return JSReceiver::CreateDataProperty(&own_lookup, value, should_throw); } |