diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2019-09-14 06:50:31 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2020-07-13 15:41:58 +0300 |
| commit | b78847c99acd2f5342a1d40f422a24ab420a127f (patch) | |
| tree | 557e92d29139e4a0e4a789c6fc2b33824b8c65b4 /deps | |
| parent | 95743dcd2501f104ecce104bdc9bf91932bd4b92 (diff) | |
deps: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/src/compiler/js-heap-broker.cc | 1 | ||||
| -rw-r--r-- | deps/v8/src/interpreter/interpreter.cc | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/deps/v8/src/compiler/js-heap-broker.cc b/deps/v8/src/compiler/js-heap-broker.cc index 8ff520921f2..37770f54e3f 100644 --- a/deps/v8/src/compiler/js-heap-broker.cc +++ b/deps/v8/src/compiler/js-heap-broker.cc @@ -4486,6 +4486,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell, GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind) : ProcessedFeedback(kGlobalAccess, slot_kind), + cell_or_context_(base::nullopt), index_and_immutable_(0 /* doesn't matter */) { DCHECK(IsGlobalICKind(slot_kind)); } diff --git a/deps/v8/src/interpreter/interpreter.cc b/deps/v8/src/interpreter/interpreter.cc index 42f0c561625..3927dd9e921 100644 --- a/deps/v8/src/interpreter/interpreter.cc +++ b/deps/v8/src/interpreter/interpreter.cc @@ -287,7 +287,7 @@ Interpreter::NewSourcePositionCollectionJob( auto job = std::make_unique<InterpreterCompilationJob>(parse_info, literal, allocator, nullptr); job->compilation_info()->SetBytecodeArray(existing_bytecode); - return job; + return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) }; } void Interpreter::ForEachBytecode( |